Skip to content

Comments

Bug 1984635: use new default leader election values to handle apiserver rollout on SNO#211

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
aojea:leader_election_sno
Jul 27, 2021
Merged

Bug 1984635: use new default leader election values to handle apiserver rollout on SNO#211
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
aojea:leader_election_sno

Conversation

@aojea
Copy link

@aojea aojea commented Jul 26, 2021 •
edited
Loading

bring new leader elections values to deal with api restart
on SNO environments.

xref: openshift/library-go#1104

Signed-off-by: Antonio Ojea aojea@redhat.com

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2021

@aojea: This pull request references Bugzilla bug 1984635, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @xingxingxia

Details

In response to this:

Bug 1984635: use leader election values to handle apiserver rollout on SNO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aojea
Copy link
Author

aojea commented Jul 26, 2021 •
edited
Loading

/assign @deads2k @sttts

@openshift-ci openshift-ci bot requested a review from xingxingxia July 26, 2021 16:27
@openshift-ci openshift-ci bot requested review from soltysh and sttts July 26, 2021 16:27
@aojea aojea changed the title Bug 1984635: use leader election values to handle apiserver rollout on SNO Bug 1984635: use new leader election values to handle apiserver rollout on SNO Jul 26, 2021
@aojea aojea changed the title Bug 1984635: use new leader election values to handle apiserver rollout on SNO Bug 1984635: use new default leader election values to handle apiserver rollout on SNO Jul 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2021

@aojea: This pull request references Bugzilla bug 1984635, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @xingxingxia

Details

In response to this:

Bug 1984635: use new default leader election values to handle apiserver rollout on SNO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bump openshift/api library
f1c0356 
bring new leader elections values to deal with api restart
on SNO environments.

Signed-off-by: Antonio Ojea <aojea@redhat.com>
@aojea aojea force-pushed the leader_election_sno branch from caff652 to f1c0356 Compare July 26, 2021 16:40
@sttts
Copy link
Contributor

sttts commented Jul 27, 2021

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2021
@openshift-merge-robot openshift-merge-robot merged commit 19f8044 into openshift:master Jul 27, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 27, 2021

@aojea: All pull requests linked via external trackers have merged:

Bugzilla bug 1984635 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1984635: use new default leader election values to handle apiserver rollout on SNO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aojea aojea mentioned this pull request Jul 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xingxingxia xingxingxia Awaiting requested review from xingxingxia

@soltysh soltysh Awaiting requested review from soltysh

@sttts sttts Awaiting requested review from sttts

Assignees

@sttts sttts

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aojea @sttts @deads2k @openshift-merge-robot