Skip to content

Bug 1960339: openshift-user-critical: unset globalDefault #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jun 10, 2021
Merged

Bug 1960339: openshift-user-critical: unset globalDefault #205

openshift-merge-robot merged 1 commit into from
Jun 10, 2021

Conversation

@vrutkovs
Copy link

@vrutkovs vrutkovs commented Jun 2, 2021 •
edited
Loading

This property doesn't render in the final object, so CVO hotloops attempting to set it.

Follow-up for #202.
Verified that its no longer hotlooping via test e2e openshift/cluster-version-operator#561,openshift/cluster-config-operator#205 aws task in cluster-bot:

$ curl -sL https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/logs/release-openshift-origin-installer-launch-aws/1400081719066890240/artifacts/launch/pods/openshift-cluster-version_cluster-version-operator-55b7ff6f99-5pz7v_cluster-version-operator.log | grep -oP "Updating \K.+ due to diff" | cut -d' ' -f1 | sort | uniq -c
     14 ClusterServiceVersion
    447 Deployment

openshift-user-critical: unset globalDefault
c0c2b5a 
This property doesn't render in the final object, so CVO hotloops attempting to set it
@vrutkovs vrutkovs mentioned this pull request Jun 2, 2021
Merged
@openshift-ci openshift-ci bot requested review from deads2k and soltysh June 2, 2021 09:36
@vrutkovs
Copy link
Author

vrutkovs commented Jun 2, 2021

/retest

@vrutkovs vrutkovs changed the title openshift-user-critical: unset globalDefault Bug 1960339: openshift-user-critical: unset globalDefault Jun 2, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jun 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2021

@vrutkovs: This pull request references Bugzilla bug 1960339, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1960339: openshift-user-critical: unset globalDefault

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2021

@vrutkovs: This pull request references Bugzilla bug 1960339, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1960339: openshift-user-critical: unset globalDefault

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs vrutkovs force-pushed the remove-globaldefault branch from c54d29a to b1e80ee Compare June 2, 2021 13:15
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2021

@vrutkovs: This pull request references Bugzilla bug 1960339, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1960339: openshift-user-critical: unset globalDefault

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs vrutkovs force-pushed the remove-globaldefault branch from b1e80ee to c0c2b5a Compare June 2, 2021 15:19
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2021

@vrutkovs: This pull request references Bugzilla bug 1960339, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1960339: openshift-user-critical: unset globalDefault

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs
Copy link
Author

vrutkovs commented Jun 2, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2021

@vrutkovs: This pull request references Bugzilla bug 1960339, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs
Copy link
Author

vrutkovs commented Jun 2, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2021

@vrutkovs: This pull request references Bugzilla bug 1960339, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @xingxingxia

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 2, 2021
@openshift-ci openshift-ci bot requested a review from xingxingxia June 2, 2021 15:27
@vrutkovs
Copy link
Author

vrutkovs commented Jun 2, 2021

/refresh

@vrutkovs
Copy link
Author

vrutkovs commented Jun 2, 2021

/retest

1 similar comment
@vrutkovs
Copy link
Author

vrutkovs commented Jun 3, 2021

/retest

@vrutkovs vrutkovs force-pushed the remove-globaldefault branch 2 times, most recently from c440784 to c0c2b5a Compare June 3, 2021 10:39
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 3, 2021

@vrutkovs: This pull request references Bugzilla bug 1960339, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @xingxingxia

Details

In response to this:

Bug 1960339: openshift-user-critical: unset globalDefault

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts
Copy link
Contributor

sttts commented Jun 7, 2021

/retest
/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2021
@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 7, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 7, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 7, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@vrutkovs
Copy link
Author

vrutkovs commented Jun 8, 2021

/test e2e-upgrade

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 9, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 9, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@vrutkovs
Copy link
Author

vrutkovs commented Jun 9, 2021

alert PodDisruptionBudgetAtLimit fired for 150 seconds with labels: {namespace="openshift-etcd", poddisruptionbudget="etcd-quorum-guard", severity="warning"}

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 9, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 9, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 9, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 9, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 9, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 10, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 10, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 10, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 10, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit c08cf7d into openshift:master Jun 10, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2021

@vrutkovs: All pull requests linked via external trackers have merged:

Bugzilla bug 1960339 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1960339: openshift-user-critical: unset globalDefault

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@soltysh soltysh Awaiting requested review from soltysh

@xingxingxia xingxingxia Awaiting requested review from xingxingxia

Assignees

@sttts sttts

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vrutkovs @sttts @openshift-bot @openshift-merge-robot