add controller to sync aws resource tags #196

staebler · 2021-04-21T04:27:38Z

Add aws_resource_tags controller. The controller will sync AWS resource tags from the spec of the infrastructure resource to the status of the resource.

/cc @deads2k

Bump to the latest github.com/openshift/api to pull in the resourceTags fields added to infrastructure.config.openshift.io.

Add aws_resource_tags controller. The controller will sync AWS resource tags from the spec of the infrastructure resource to the status of the resource.

openshift-ci-robot · 2021-04-21T04:27:54Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: staebler
To complete the pull request process, please assign deads2k after the PR has been reviewed.
You can assign the PR to them by writing /assign @deads2k in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

staebler · 2021-04-21T04:28:01Z

/hold

This is using a fork of openshift/api until openshift/api#905 merges.

openshift-ci-robot · 2021-04-21T04:28:45Z

@staebler: This pull request references Bugzilla bug 1950113, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

Details

In response to this:

Bug 1950113: add controller to sync aws resource tags

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-04-21T04:31:13Z

@staebler: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/verify	`7417f24`	link	`/test verify`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

deads2k · 2021-04-21T12:39:32Z

pkg/operator/aws_resource_tags/controller.go

+		currentResourceTags = currentInfra.Status.PlatformStatus.AWS.ResourceTags
+	}
+
+	if len(desiredResourceTags) == 0 && len(currentResourceTags) == 0 {


seems like this case is handled by the deepequal on the next line. is it not?

deads2k · 2021-04-21T12:40:03Z

pkg/operator/aws_resource_tags/controller.go

+	}
+	currentInfra.Status.PlatformStatus.AWS.ResourceTags = desiredResourceTags
+
+	_, err = c.infraClient.UpdateStatus(ctx, currentInfra, metav1.UpdateOptions{})


I think an event on successful update is also warranted.

deads2k · 2021-04-21T12:40:42Z

pkg/operator/aws_resource_tags/controller.go

+	if currentInfra.Status.PlatformStatus.AWS == nil {
+		currentInfra.Status.PlatformStatus.AWS = &configv1.AWSPlatformStatus{}
+	}
+	currentInfra.Status.PlatformStatus.AWS.ResourceTags = desiredResourceTags


Unless order matters, please sort the status resourcetags.

deads2k · 2021-04-21T12:41:46Z

minor comments, but I think the API and additional validation make sense and provide clear indications of what can and cannot be done.

openshift-ci-robot · 2021-04-23T16:33:36Z

@staebler: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

add controller to sync aws resource tags

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-04-26T16:30:48Z

@staebler: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-07-25T20:28:22Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot · 2021-08-25T00:17:10Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-bot · 2021-09-24T02:48:43Z

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci · 2021-09-24T02:49:10Z

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

staebler added 2 commits April 20, 2021 21:41

vendor: bump openshift/api for resourceTags in infrastructure

77d81fe

Bump to the latest github.com/openshift/api to pull in the resourceTags fields added to infrastructure.config.openshift.io.

add controller to sync aws resource tags

7417f24

Add aws_resource_tags controller. The controller will sync AWS resource tags from the spec of the infrastructure resource to the status of the resource.

openshift-ci-robot requested a review from deads2k April 21, 2021 04:27

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 21, 2021

staebler changed the title ~~add controller to sync aws resource tags~~ Bug 1950113: add controller to sync aws resource tags Apr 21, 2021

openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 21, 2021

deads2k reviewed Apr 21, 2021

View reviewed changes

staebler changed the title ~~Bug 1950113: add controller to sync aws resource tags~~ add controller to sync aws resource tags Apr 23, 2021

openshift-ci-robot removed bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 23, 2021

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 26, 2021

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 25, 2021

openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 25, 2021

openshift-ci bot closed this Sep 24, 2021

add controller to sync aws resource tags #196

add controller to sync aws resource tags #196

Uh oh!

Conversation

staebler commented Apr 21, 2021

Uh oh!

openshift-ci-robot commented Apr 21, 2021

Uh oh!

staebler commented Apr 21, 2021

Uh oh!

openshift-ci-robot commented Apr 21, 2021

Uh oh!

openshift-ci bot commented Apr 21, 2021

Uh oh!

deads2k Apr 21, 2021

Choose a reason for hiding this comment

Uh oh!

deads2k Apr 21, 2021

Choose a reason for hiding this comment

Uh oh!

deads2k Apr 21, 2021

Choose a reason for hiding this comment

Uh oh!

deads2k commented Apr 21, 2021

Uh oh!

openshift-ci-robot commented Apr 23, 2021

Uh oh!

openshift-ci bot commented Apr 26, 2021

Uh oh!

openshift-bot commented Jul 25, 2021

Uh oh!

openshift-bot commented Aug 25, 2021

Uh oh!

openshift-bot commented Sep 24, 2021

Uh oh!

openshift-ci bot commented Sep 24, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants