Skip to content

create bootstrap-manifests directory #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
deads2k merged 1 commit into from
Feb 13, 2019
Merged

create bootstrap-manifests directory #16

deads2k merged 1 commit into from
Feb 13, 2019

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Feb 12, 2019

this may solve the issue from openshift/installer#1187

/assign @mfojtik

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 12, 2019
@deads2k
Copy link
Contributor Author

deads2k commented Feb 13, 2019

/retest

@sttts
Copy link
Contributor

sttts commented Feb 13, 2019

This is not enough.

the Dockerfile has to copy manifests/* to /usr/share/bootkube/manifests/manifests. Note the second "manifests".

/usr/share/bootkube/manifests should be better called /usr/share/bootkube/templates. Then it would be clearer.

@sttts
Copy link
Contributor

sttts commented Feb 13, 2019

/assign @sttts

@deads2k deads2k force-pushed the prime-bootstrapmanifests branch from 344fadc to fbf5181 Compare February 13, 2019 13:05
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 13, 2019
@sttts
Copy link
Contributor

sttts commented Feb 13, 2019

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2019
@deads2k deads2k added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: deads2k, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 13, 2019

@deads2k: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws fbf5181 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Contributor Author

deads2k commented Feb 13, 2019

isntall completed merging

@deads2k deads2k merged commit aa1805e into openshift:master Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mfojtik mfojtik

@sttts sttts

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@deads2k @sttts @openshift-ci-robot @mfojtik