Skip to content

Conversation

@marun
Copy link
Contributor

@marun marun commented Jan 24, 2020

openshift/cluster-kube-apiserver-operator#727 requires the addition of the serviceAccountIssuer field to the Authentication.config.openshift.io CRD which was recently merged to the API repo. Since that CRD is installed by the cluster-config-operator, it's necessary to bump deps to pick up the API change and this PR will need to merge before 727 can pass its tests.

/cc @sttts @deads2k

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 24, 2020
@sttts
Copy link
Contributor

sttts commented Jan 24, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marun, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@marun marun changed the title bump(*) Convert to go mod and bump(*) Jan 24, 2020
go.mod Outdated
github.com/prometheus/client_golang v1.0.0
github.com/spf13/cobra v0.0.5
github.com/spf13/pflag v1.0.3
k8s.io/apiextensions-apiserver v0.0.0-20190918161926-8f644eb6e783 // indirect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be v0.17.0

@openshift-ci-robot
Copy link

@marun: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws d146d2e link /test e2e-aws
ci/prow/images d146d2e link /test images
ci/prow/e2e-aws-upgrade d146d2e link /test e2e-aws-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@marun
Copy link
Contributor Author

marun commented Jan 24, 2020

Replaced by #113

@marun marun closed this Jan 24, 2020
@marun marun deleted the bump-deps branch January 24, 2020 17:12
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 24, 2020
@openshift-ci-robot
Copy link

@marun: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants