-
Notifications
You must be signed in to change notification settings - Fork 142
Convert to go mod and bump(*) #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marun, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
go.mod
Outdated
| github.com/prometheus/client_golang v1.0.0 | ||
| github.com/spf13/cobra v0.0.5 | ||
| github.com/spf13/pflag v1.0.3 | ||
| k8s.io/apiextensions-apiserver v0.0.0-20190918161926-8f644eb6e783 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be v0.17.0
|
@marun: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Replaced by #113 |
|
@marun: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift/cluster-kube-apiserver-operator#727 requires the addition of the serviceAccountIssuer field to the
Authentication.config.openshift.ioCRD which was recently merged to the API repo. Since that CRD is installed by the cluster-config-operator, it's necessary to bump deps to pick up the API change and this PR will need to merge before 727 can pass its tests./cc @sttts @deads2k