Skip to content

Conversation

@patrickdillon
Copy link
Contributor

We need to pull in the changes from openshift/api#541 so that the cluster-infrastructure-02-config.yml manifest generated by the installer can be correctly applied.

This commit was created by running make update-deps.

It seems extremely large so perhaps I am doing something very wrong. Guidance would be appreciated.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 22, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: patrickdillon
To complete the pull request process, please assign soltysh
You can assign the PR to them by writing /assign @soltysh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@patrickdillon
Copy link
Contributor Author

/retest

This bumps the API, specifically to include updates for VSphere infrastructure.
make verify-deps is currently erring with a reference to bindata. This includes a new import for go-bindata.

This commit is a result of running: make update-deps.
@patrickdillon patrickdillon force-pushed the bump-api-vsphere-infra branch from 3d4f98e to 967626a Compare January 22, 2020 19:41
@patrickdillon
Copy link
Contributor Author

/close
in favor of #111

@openshift-ci-robot
Copy link

@patrickdillon: Closed this PR.

Details

In response to this:

/close
in favor of #111

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@patrickdillon
Copy link
Contributor Author

/reopen
/test images
just need to grab the image from ci

@openshift-ci-robot
Copy link

@patrickdillon: Reopened this PR.

Details

In response to this:

/reopen
/test images
just need to grab the image from ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@patrickdillon
Copy link
Contributor Author

/test images

@patrickdillon
Copy link
Contributor Author

/close

@openshift-ci-robot
Copy link

@patrickdillon: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@patrickdillon: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify-deps 967626a link /test verify-deps
ci/prow/verify 967626a link /test verify
ci/prow/e2e-aws 967626a link /test e2e-aws
ci/prow/e2e-aws-upgrade 967626a link /test e2e-aws-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants