-
Notifications
You must be signed in to change notification settings - Fork 74
Bug 2033489: allow baremetal platform to skip syncing #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
on baremetal there is no credential to sync from, this change allows cccmo to skip syncing on baremetal. it also adds a test clause for sync skipping on baremetal.
|
@elmiko: This pull request references Bugzilla bug 2033489, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
/bugzilla refresh |
|
@elmiko: This pull request references Bugzilla bug 2033489, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
i am approving this as it fixes a critical bug that is holding up ci, and also because i will likely be asleep when @zaneb's testing is concluded. i am also placing a hold on this that folks should feel free to remove when, and hopefully if, the tests are passing. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-metal-ipi |
|
@sadasu: The specified target(s) for
The following commands are available to trigger optional jobs:
Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Local test on metal succeeded |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@elmiko: All pull requests linked via external trackers have merged: Bugzilla bug 2033489 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
on baremetal there is no credential to sync from, this change allows
cccmo to skip syncing on baremetal. it also adds a test clause for
sync skipping on baremetal.