Skip to content

Conversation

@elmiko
Copy link
Contributor

@elmiko elmiko commented Dec 17, 2021

on baremetal there is no credential to sync from, this change allows
cccmo to skip syncing on baremetal. it also adds a test clause for
sync skipping on baremetal.

on baremetal there is no credential to sync from, this change allows
cccmo to skip syncing on baremetal. it also adds a test clause for
sync skipping on baremetal.
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 17, 2021

@elmiko: This pull request references Bugzilla bug 2033489, which is invalid:

  • expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2033489: allow baremetal platform to skip syncing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from JoelSpeed and lobziik December 17, 2021 02:45
@zaneb
Copy link
Member

zaneb commented Dec 17, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2021
@elmiko
Copy link
Contributor Author

elmiko commented Dec 17, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 17, 2021

@elmiko: This pull request references Bugzilla bug 2033489, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from sunzhaohua2 December 17, 2021 02:47
@elmiko
Copy link
Contributor Author

elmiko commented Dec 17, 2021

i am approving this as it fixes a critical bug that is holding up ci, and also because i will likely be asleep when @zaneb's testing is concluded. i am also placing a hold on this that folks should feel free to remove when, and hopefully if, the tests are passing.
/approve
/hold until zaneb says so

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2021
@sadasu
Copy link

sadasu commented Dec 17, 2021

/test e2e-metal-ipi

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 17, 2021

@sadasu: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-aws
  • /test e2e-aws-ccm
  • /test e2e-aws-upgrade
  • /test fmt
  • /test images
  • /test lint
  • /test unit
  • /test vendor
  • /test vet

The following commands are available to trigger optional jobs:

  • /test e2e-aws-ccm-install
  • /test e2e-azure
  • /test e2e-azure-ccm
  • /test e2e-azure-ccm-install
  • /test e2e-azure-upgrade
  • /test e2e-gcp-ccm
  • /test e2e-gcp-ccm-install
  • /test e2e-openstack-ccm
  • /test e2e-vsphere-ccm
  • /test e2e-vsphere-ccm-install

Use /test all to run all jobs.

Details

In response to this:

/test e2e-metal-ipi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zaneb
Copy link
Member

zaneb commented Dec 17, 2021

Local test on metal succeeded
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2021
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit a9bf4d4 into openshift:master Dec 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 17, 2021

@elmiko: All pull requests linked via external trackers have merged:

Bugzilla bug 2033489 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2033489: allow baremetal platform to skip syncing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants