Skip to content

Added enablePublicEndpoint environmental variable to IBM Cloud deployment file#148

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Karthik-K-N:support-public-endpoint
Nov 22, 2021
Merged

Added enablePublicEndpoint environmental variable to IBM Cloud deployment file#148
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Karthik-K-N:support-public-endpoint

Conversation

@Karthik-K-N
Copy link
Copy Markdown
Member

Power VS platform used IBM Cloud Provider and by default the ibm cloud services like IAM are accessed via private endpoint, This PR contains the changes to use Public endpoints for Power VS platform by setting up a environmental variable in deployment file.

Related to Enhancement: openshift/enhancements#736
Earlier Power VS PR: #129

@Karthik-K-N
Copy link
Copy Markdown
Member Author

/cc @JoelSpeed @elmiko

@openshift-ci openshift-ci Bot requested a review from elmiko November 22, 2021 04:22
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 22, 2021

@Karthik-K-N: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ccm d64dbaa link false /test e2e-gcp-ccm
ci/prow/e2e-vsphere-ccm d64dbaa link false /test e2e-vsphere-ccm
ci/prow/e2e-vsphere-ccm-install d64dbaa link false /test e2e-vsphere-ccm-install
ci/prow/e2e-gcp-ccm-install d64dbaa link false /test e2e-gcp-ccm-install
ci/prow/e2e-azure-ccm-install d64dbaa link false /test e2e-azure-ccm-install
ci/prow/e2e-azure-upgrade d64dbaa link false /test e2e-azure-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Copy Markdown
Contributor

/approve

Seems reasonable to me

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2021
Copy link
Copy Markdown
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2021
@openshift-merge-robot openshift-merge-robot merged commit 50fb4eb into openshift:master Nov 22, 2021
@Karthik-K-N Karthik-K-N deleted the support-public-endpoint branch November 24, 2021 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants