[release-4.9] Bug 2015503: User CA bundle sync controller #138

lobziik · 2021-10-19T11:46:34Z

Manual cherry-pick of #136

Needed for enable installation of OpenShift on Azure Stack with custom CA.

Related installer bug: https://bugzilla.redhat.com/show_bug.cgi?id=2010921

In order to add more similar controllers within this binary, cloud-config-sync-controller binary renamed to config-sync controller (cherry picked from commit 4ff5bea)

Introduce separate controller for sync `user-ca-bundle` from `openshift-config` namespace to target CCCMO namespace for use user defined certificate authority during communication with cloud-provider (cherry picked from commit 30aa4b8)

(cherry picked from commit 3e224e1)

(cherry picked from commit d1d1d30)

openshift-ci · 2021-10-19T11:46:39Z

@lobziik: This pull request references Bugzilla bug 2015503, which is invalid:

expected dependent Bugzilla bug 2015493 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead
expected dependent Bugzilla bug 2015493 to target a release in 4.10.0, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2015503: User CA bundle sync controller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lobziik · 2021-10-19T11:47:31Z

/bugzilla refresh

openshift-ci · 2021-10-19T11:47:34Z

@lobziik: This pull request references Bugzilla bug 2015503, which is invalid:

expected dependent Bugzilla bug 2015493 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lobziik · 2021-10-19T11:49:45Z

/assign @JoelSpeed @elmiko @Fedosin

JoelSpeed · 2021-10-19T12:23:19Z

/approve

openshift-ci · 2021-10-19T12:23:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2021-10-19T12:37:35Z

@lobziik: This pull request references Bugzilla bug 2015503, which is invalid:

expected dependent Bugzilla bug 2015493 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.9] Bug 2015503: User CA bundle sync controller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

elmiko

thanks Denis
/lgtm

openshift-bot · 2021-10-19T16:09:46Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-19T16:45:47Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-19T17:09:52Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-19T17:33:43Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-19T17:45:46Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-19T18:22:20Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-19T18:45:46Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-19T18:57:48Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-06T18:28:49Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-06T18:52:32Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

patrickdillon · 2021-12-06T21:34:48Z

/bugzilla refresh

openshift-ci · 2021-12-06T21:34:52Z

@patrickdillon: This pull request references Bugzilla bug 2015503, which is invalid:

expected dependent Bugzilla bug 2015493 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mgahagan73 · 2021-12-06T21:42:47Z

/lgtm

I have tested and confirmed this is working in our ASH environment

elmiko · 2021-12-06T21:44:50Z

/backport-risk-assessed

openshift-bot · 2021-12-06T23:30:30Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-07T01:00:45Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-12-07T01:00:49Z

@openshift-bot: This pull request references Bugzilla bug 2015503, which is invalid:

expected dependent Bugzilla bug 2015493 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sunzhaohua2 · 2021-12-07T01:22:39Z

/label cherry-pick-approved

sunzhaohua2 · 2021-12-07T01:39:35Z

/bugzilla cc-qa

openshift-ci · 2021-12-07T01:39:38Z

@sunzhaohua2: This pull request references Bugzilla bug 2015503, which is invalid:

expected dependent Bugzilla bug 2015493 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla cc-qa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sunzhaohua2 · 2021-12-07T01:42:47Z

/bugzilla cc-qa

openshift-ci · 2021-12-07T01:42:53Z

@sunzhaohua2: This pull request references Bugzilla bug 2015503, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.z) matches configured target release for branch (4.9.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2015493 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 2015493 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
bug has dependents

Requesting review from QA contact:
/cc @sunzhaohua2

Details

In response to this:

/bugzilla cc-qa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sunzhaohua2 · 2021-12-07T01:43:08Z

/lgtm

sunzhaohua2 · 2021-12-07T01:43:18Z

/label qe-approved

patrickdillon · 2021-12-07T01:45:33Z

/bugzilla refresh

openshift-ci · 2021-12-07T01:45:38Z

@patrickdillon: This pull request references Bugzilla bug 2015503, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.z) matches configured target release for branch (4.9.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2015493 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 2015493 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
bug has dependents

Requesting review from QA contact:
/cc @sunzhaohua2

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

elmiko · 2021-12-07T02:30:18Z

/label backport-risk-assessed

elmiko · 2021-12-07T02:30:57Z

/test e2e-aws-ccm

openshift-ci · 2021-12-07T02:31:29Z

@lobziik: All pull requests linked via external trackers have merged:

openshift/cluster-cloud-controller-manager-operator#138

Bugzilla bug 2015503 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.9] Bug 2015503: User CA bundle sync controller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lobziik added 4 commits October 19, 2021 13:32

Rename cloud-config-sync-controller binary to config-sync-controllers

b04ea0f

In order to add more similar controllers within this binary, cloud-config-sync-controller binary renamed to config-sync controller (cherry picked from commit 4ff5bea)

Introduce trusted CA sync controller

c81bba5

Introduce separate controller for sync `user-ca-bundle` from `openshift-config` namespace to target CCCMO namespace for use user defined certificate authority during communication with cloud-provider (cherry picked from commit 30aa4b8)

CA sync controller description doc

bcbe23b

(cherry picked from commit 3e224e1)

Add trusted ca mounts to all CCMs

fa9433a

(cherry picked from commit d1d1d30)

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 19, 2021

lobziik changed the title ~~Bug 2015503: User CA bundle sync controller~~ [release-4.9] Bug 2015503: User CA bundle sync controller Oct 19, 2021

openshift-ci bot requested review from mandre and mdbooth October 19, 2021 11:49

openshift-ci bot assigned elmiko, Fedosin and JoelSpeed Oct 19, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2021

elmiko reviewed Oct 19, 2021

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2021

openshift-ci bot assigned mgahagan73 Dec 6, 2021

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 7, 2021

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 7, 2021

openshift-ci bot requested a review from sunzhaohua2 December 7, 2021 01:42

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Dec 7, 2021

openshift-ci bot assigned sunzhaohua2 Dec 7, 2021

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Dec 7, 2021

openshift-merge-robot merged commit 46be73e into openshift:release-4.9 Dec 7, 2021

[release-4.9] Bug 2015503: User CA bundle sync controller #138

[release-4.9] Bug 2015503: User CA bundle sync controller #138

Uh oh!

Conversation

lobziik commented Oct 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Oct 19, 2021

Uh oh!

lobziik commented Oct 19, 2021

Uh oh!

openshift-ci bot commented Oct 19, 2021

Uh oh!

lobziik commented Oct 19, 2021

Uh oh!

JoelSpeed commented Oct 19, 2021

Uh oh!

openshift-ci bot commented Oct 19, 2021

Uh oh!

openshift-ci bot commented Oct 19, 2021

Uh oh!

elmiko left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-bot commented Oct 19, 2021

Uh oh!

openshift-bot commented Oct 19, 2021

Uh oh!

openshift-bot commented Oct 19, 2021

Uh oh!

openshift-bot commented Oct 19, 2021

Uh oh!

openshift-bot commented Oct 19, 2021

Uh oh!

openshift-bot commented Oct 19, 2021

Uh oh!

openshift-bot commented Oct 19, 2021

Uh oh!

openshift-bot commented Oct 19, 2021

Uh oh!

openshift-bot commented Dec 6, 2021

Uh oh!

openshift-bot commented Dec 6, 2021

Uh oh!

patrickdillon commented Dec 6, 2021

Uh oh!

openshift-ci bot commented Dec 6, 2021

Uh oh!

mgahagan73 commented Dec 6, 2021

Uh oh!

elmiko commented Dec 6, 2021

Uh oh!

openshift-bot commented Dec 6, 2021

Uh oh!

openshift-bot commented Dec 7, 2021

Uh oh!

openshift-ci bot commented Dec 7, 2021

Uh oh!

sunzhaohua2 commented Dec 7, 2021

Uh oh!

sunzhaohua2 commented Dec 7, 2021

Uh oh!

openshift-ci bot commented Dec 7, 2021

Uh oh!

sunzhaohua2 commented Dec 7, 2021

Uh oh!

openshift-ci bot commented Dec 7, 2021

Uh oh!

sunzhaohua2 commented Dec 7, 2021

Uh oh!

sunzhaohua2 commented Dec 7, 2021

Uh oh!

patrickdillon commented Dec 7, 2021

Uh oh!

openshift-ci bot commented Dec 7, 2021

Uh oh!

elmiko commented Dec 7, 2021

Uh oh!

elmiko commented Dec 7, 2021

Uh oh!

lobziik commented Oct 19, 2021 •

edited

Loading