Skip to content

Comments

Bug 1994480: Update dependencies to K8s 1.22#107

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
JoelSpeed:k8s-1.22
Aug 23, 2021
Merged

Bug 1994480: Update dependencies to K8s 1.22#107
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
JoelSpeed:k8s-1.22

Conversation

@JoelSpeed
Copy link
Contributor

@JoelSpeed JoelSpeed commented Aug 19, 2021

We should make sure our dependencies are up to date before the 4.9 code freeze

@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Aug 19, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 19, 2021

@JoelSpeed: This pull request references Bugzilla bug 1994480, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

Details

In response to this:

Bug 1994480: Update dependencies to K8s 1.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 19, 2021
@openshift-ci openshift-ci bot requested a review from sunzhaohua2 August 19, 2021 08:52
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 19, 2021
@openshift-ci openshift-ci bot requested review from Fedosin and mandre August 19, 2021 08:53
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 19, 2021
@JoelSpeed
Ensure HOME is set for cache setup
f8a3c5e 
When the HOME directory is unset or is set to /, kubebuilder tries to 
create a cache directory but fails. Make sure in these cases that we set 
it to a temp folder so that the test can create its cache
Fedosin
Fedosin approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@Fedosin Fedosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2021
@openshift-ci openshift-ci bot mentioned this pull request Aug 20, 2021
Merged
@lobziik
Copy link
Contributor

lobziik commented Aug 23, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2021
@lobziik
Copy link
Contributor

lobziik commented Aug 23, 2021

/retest

@openshift-merge-robot openshift-merge-robot merged commit cd38337 into openshift:master Aug 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2021

@JoelSpeed: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1994480 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1994480: Update dependencies to K8s 1.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2021

@JoelSpeed: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-openstack-ccm f8a3c5e link /test e2e-openstack-ccm
ci/prow/e2e-azure f8a3c5e link /test e2e-azure
ci/prow/e2e-azure-ccm f8a3c5e link /test e2e-azure-ccm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot mentioned this pull request Aug 23, 2021
Merged
@JoelSpeed JoelSpeed deleted the k8s-1.22 branch August 23, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunzhaohua2 sunzhaohua2 Awaiting requested review from sunzhaohua2

@mandre mandre Awaiting requested review from mandre

1 more reviewer

@Fedosin Fedosin Fedosin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lobziik lobziik

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JoelSpeed @lobziik @Fedosin @openshift-merge-robot