Skip to content

Conversation

@JoelSpeed
Copy link
Contributor

Currently the operator can't run because pod security admission is enforced and we don't have the correct configuration.

For now, we run this as privileged (xref openshift/machine-api-operator#924) but over time will restrict this down as per the requirements of the workloads in this project.

@lobziik
Copy link

lobziik commented Sep 1, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2022
@JoelSpeed
Copy link
Contributor Author

Made a mistake, put them as annotations instead of labels, have updated

@JoelSpeed
Copy link
Contributor Author

Having reviewed the latest test runs I can see the CAPI operator is running again now.
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2022
@lobziik
Copy link

lobziik commented Sep 2, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD fb11418 and 2 for PR HEAD 8a5c63b in total

@JoelSpeed
Copy link
Contributor Author

/override ci/prow/e2e-aws-capi-techpreview

This actually did pass, but the must gather panicked.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 2, 2022

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-capi-techpreview

Details

In response to this:

/override ci/prow/e2e-aws-capi-techpreview

This actually did pass, but the must gather panicked.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoelSpeed
Copy link
Contributor Author

/retest-required

@JoelSpeed
Copy link
Contributor Author

This can't pass right now because the CCMs are also broken. Need to merge this and openshift/cluster-cloud-controller-manager-operator#202 to resolve the issue.

/override ci/prow/e2e-aws-techpreview
/override ci/prow/e2e-azure-techpreview
/override ci/prow/e2e-gcp-techpreview
/override ci/prow/e2e-gcp-capi-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 5, 2022

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-techpreview, ci/prow/e2e-azure-techpreview, ci/prow/e2e-gcp-capi-techpreview, ci/prow/e2e-gcp-techpreview

Details

In response to this:

This can't pass right now because the CCMs are also broken. Need to merge this and openshift/cluster-cloud-controller-manager-operator#202 to resolve the issue.

/override ci/prow/e2e-aws-techpreview
/override ci/prow/e2e-azure-techpreview
/override ci/prow/e2e-gcp-techpreview
/override ci/prow/e2e-gcp-capi-techpreview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoelSpeed
Copy link
Contributor Author

/override ci/prow/e2e-aws-capi-techpreview

Tests passed, gather failed

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 5, 2022

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-capi-techpreview

Details

In response to this:

/override ci/prow/e2e-aws-capi-techpreview

Tests passed, gather failed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 5, 2022

@JoelSpeed: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit c1ada63 into openshift:main Sep 5, 2022
@JoelSpeed JoelSpeed deleted the security-context branch September 5, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants