-
Notifications
You must be signed in to change notification settings - Fork 52
Set privileged pod security for openshift-cluster-api namespace #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set privileged pod security for openshift-cluster-api namespace #73
Conversation
|
/lgtm |
5ac9719 to
8a5c63b
Compare
|
Made a mistake, put them as annotations instead of labels, have updated |
|
Having reviewed the latest test runs I can see the CAPI operator is running again now. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/override ci/prow/e2e-aws-capi-techpreview This actually did pass, but the must gather panicked. |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-capi-techpreview DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required |
|
This can't pass right now because the CCMs are also broken. Need to merge this and openshift/cluster-cloud-controller-manager-operator#202 to resolve the issue. /override ci/prow/e2e-aws-techpreview |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-techpreview, ci/prow/e2e-azure-techpreview, ci/prow/e2e-gcp-capi-techpreview, ci/prow/e2e-gcp-techpreview DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/e2e-aws-capi-techpreview Tests passed, gather failed |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-capi-techpreview DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@JoelSpeed: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Currently the operator can't run because pod security admission is enforced and we don't have the correct configuration.
For now, we run this as privileged (xref openshift/machine-api-operator#924) but over time will restrict this down as per the requirements of the workloads in this project.