Revert "Merge pull request #20 from alexander-demichev/annotations"

[dgoodwin]

This reverts commit 3d1c893, reversing
changes made to d4e3c4f.

The original pr in #20 looks to have broken payload delivery for the org, so per policy we need to revert as quickly as possible. Ideally you can then revert the revert, and layer in the fixed commits. However in this case the fix might be to the tests in the origin repo.

You can see whats taking down payloads here: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-ci-4.10-e2e-aws-ovn-upgrade/1470831487283630080

fail [github.com/openshift/origin/test/extended/operators/operators.go:151]: unexpected operator status versions cluster-api:
[]v1.OperandVersion{v1.OperandVersion{Name:"operator", Version:"4.10.0-0.ci-2021-12-14-120025"}}
Expected
    <string>: 4.10.0-0.ci-2021-12-14-120025
to equal
    <string>: 4.10.0-0.ci-2021-12-14-185120

Essentially we have tests that assert all operators hanging on the ClusterVersion must reach the correct upgrade level, and I suspect that annotation you added is to explicitly not do that, so presumably the test needs an update.

I notice you don't have any upgrade e2e jobs on this repo so that is likely how it slipped in. You may not want upgrade support so that is reasonable, but it might be good to add one just to catch this kind of thing as you are part of the payload, and that does tie you into upgrades even if your desired behavior is a little different.

[alexander-demicev]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demichev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [alexander-demichev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@dgoodwin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-capi-techpreview	96219a0	link	true	/test e2e-aws-capi-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[JoelSpeed]

/hold We think force accepting a payload is a better solution than reverting

[alexander-demicev]

/close

[openshift-ci]

@alexander-demichev: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.