start: wait until pods ready #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
soltysh
pushed a commit
to soltysh/cluster-bootstrap
that referenced
this pull request
Nov 28, 2018
This lets us drop the grep, which may give some very slight performance increase. But mostly this just reduces the complexity of a pipe, which we've had for GOFMT since b4f2d7d (Initial asset rendering & secure api endpoint, 2016-03-21, openshift#2). Both ! and -path are in POSIX [1]. [1]: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/find.html
Contributor
Author
|
/meow |
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Already merged upstream: kubernetes-retired/bootkube#1030