provisioning controller: set correct status when platform=baremetal and no CR is found#75
provisioning controller: set correct status when platform=baremetal and no CR is found#75stbenjam wants to merge 1 commit intoopenshift:masterfrom
Conversation
…nd no CR is found Assisted deploys with platform=baremetal, but without any provisioning CR. I believe the correct fix for this is to set the operator to Available=true, Disabled=true, Progressing=false, and requeue to wait to see if a provisioning CR is created.
|
/test e2e-metal-assisted |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@stbenjam: The specified target(s) for
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| } | ||
|
|
||
| // We're disabled, but requeue in case we get a provisioning CR | ||
| return ctrl.Result{}, fmt.Errorf("no provisioning CR found; will remain Disabled until CR available") |
There was a problem hiding this comment.
I'm not entirely clear if this is the right fix; will we hit the Reconcile loop if there's no CR at all? This might need to go to main.
There was a problem hiding this comment.
| return ctrl.Result{}, fmt.Errorf("no provisioning CR found; will remain Disabled until CR available") | |
| return ctrl.Result{}, nil |
We are watching the CR so we will get a Reconcile if one is created/updated. this will just cause a lot of unnecessary Reconcile calls
There was a problem hiding this comment.
I guess we need to check in main; assisted is still failing and looking at the logs it looks like it does start but we're never reconciling which makes sense if there's no CR at all yet.
There was a problem hiding this comment.
yeah, this will only hit if you delete the cr. We probably need to initialize the status to Unsupported in case the cr never gets created
|
/test e2e-metal-assisted |
|
@stbenjam: The specified target(s) for
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-metal-assisted |
|
@stbenjam: The specified target(s) for
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/refresh |
|
/test e2e-metal-assisted |
2 similar comments
|
/test e2e-metal-assisted |
|
/test e2e-metal-assisted |
|
@stbenjam: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/close Fixed by #81 |
|
@stbenjam: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
Assisted deploys with platform=baremetal, but without any provisioning
CR. I believe the correct fix for this is to set the operator to
Available=true, Disabled=true, Progressing=false, and requeue to wait to
see if a provisioning CR is created.