Skip to content

OCPEDGE-1607: feat: add arbiter node selector #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Feb 19, 2025
Merged

OCPEDGE-1607: feat: add arbiter node selector #460

openshift-merge-bot merged 1 commit into from
Feb 19, 2025

Conversation

@eggfoobar
Copy link
Contributor

@eggfoobar eggfoobar commented Jan 5, 2025 •
edited
Loading

Per Arbiter EP: openshift/enhancements#1674

Adding a label or check for arbiter as well as master when the provisioning controller is looking to update the mac address for the machines.

@eggfoobar
feat: add arbiter node selector
ad955be 
Signed-off-by: ehila <ehila@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 5, 2025
@openshift-ci openshift-ci bot requested review from andfasano and elfosardo January 5, 2025 09:18
@eggfoobar eggfoobar changed the title WIP: feat: add arbiter node selector feat: add arbiter node selector Jan 27, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 27, 2025
@eggfoobar eggfoobar mentioned this pull request Jan 27, 2025
Merged
@eggfoobar
Copy link
Contributor Author

eggfoobar commented Feb 11, 2025

/retest

@eggfoobar eggfoobar changed the title feat: add arbiter node selector OCPEDGE-1607: feat: add arbiter node selector Feb 14, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 14, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 14, 2025 •
edited by openshift-ci bot
Loading

@eggfoobar: This pull request references OCPEDGE-1607 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 18, 2025 •
edited by openshift-ci bot
Loading

@eggfoobar: This pull request references OCPEDGE-1607 which is a valid jira issue.

Details

In response to this:

Per Arbiter EP: openshift/enhancements#1674

Adding a label or check for arbiter as well as master when the provisioning controller is looking to update the mac address for the machines.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eggfoobar
Copy link
Contributor Author

eggfoobar commented Feb 18, 2025

/retest-required

@honza
Copy link
Member

honza commented Feb 18, 2025

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, honza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2025
@honza
Copy link
Member

honza commented Feb 18, 2025

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Feb 18, 2025
@elfosardo
Copy link
Contributor

elfosardo commented Feb 19, 2025

/retest

@elfosardo
Copy link
Contributor

elfosardo commented Feb 19, 2025

/lgtm
failures are really not related to this change

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit c7442bd into openshift:main Feb 19, 2025
16 of 18 checks passed
@openshift-bot
Copy link

openshift-bot commented Feb 19, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-baremetal-operator
This PR has been included in build ose-cluster-baremetal-operator-container-v4.19.0-202502191409.p0.gc7442bd.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andfasano andfasano Awaiting requested review from andfasano

@elfosardo elfosardo Awaiting requested review from elfosardo

Assignees

@elfosardo elfosardo

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eggfoobar @openshift-ci-robot @honza @elfosardo @openshift-bot