Add Owns(Secret, Deployment and ClusterOperator) to be watched#40
Merged
openshift-merge-robot merged 5 commits intoopenshift:masterfrom Nov 5, 2020
Merged
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
asalkeld
force-pushed
the
watch-owned-resources
branch
from
3c18e3a to
826ebf7
Compare
openshift-ci-robot
added
the
approved
asalkeld
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
asalkeld
force-pushed
the
watch-owned-resources
branch
from
826ebf7 to
4626e7e
Compare
dhellmann
reviewed
Oct 26, 2020
asalkeld
force-pushed
the
watch-owned-resources
branch
from
4626e7e to
e8938b9
Compare
asalkeld
force-pushed
the
watch-owned-resources
branch
from
e8938b9 to
cef9126
Compare
asalkeld
changed the title
asalkeld
force-pushed
the
watch-owned-resources
branch
3 times, most recently
from
de12be4 to
e54418a
Compare
sadasu
reviewed
Nov 3, 2020
Contributor
sadasu
left a comment
sadasu
left a comment
There was a problem hiding this comment.
This is clever. I have a couple of minor questions inline.
- Don't duplicate the definition of the clusterOperator note if created in code there is already a divergence (missing annotation) - make the yaml manifest the master copy - at each reconcile make sure ownership and status is correct
asalkeld
force-pushed
the
watch-owned-resources
branch
from
e54418a to
b9ca309
Compare
sadasu
approved these changes
Nov 5, 2020
Contributor
sadasu
left a comment
sadasu
left a comment
There was a problem hiding this comment.
/lgtm
Thanks for taking care of my comments.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asalkeld, sadasu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main objective
Make sure that if owned resources are deleted or modified, the Reconcile is run to fix these resources.
Owned resources are
Note to reviewers
This may make sense to review by commit.
This commit does the following