Bug 2037483: Allow CBO to list Pods only in the openshift-machine-api namespace#227
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sadasu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test e2e-metal-ipi-virtualmedia |
|
I think the current permissions added in #225 allow us to list Pods in every namespace - so it will be working, but we should definitely narrow it down to just openshift-machine-api. |
|
/retest |
|
/test e2e-metal-ipi-ovn-ipv6 |
sadasu
changed the title
openshift-ci
bot
added
bugzilla/severity-medium
|
@sadasu: This pull request references Bugzilla bug 2037483, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (augol@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
sadasu
changed the title
|
Good point, maybe we can also remove these permissions in this PR |
|
/test e2e-agnostic Seems like a temporary error |
|
/test e2e-metal-ipi-virtualmedia Maybe this job is the main indicator |
|
@sadasu: This pull request references Bugzilla bug 2037483, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (augol@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@sadasu: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@sadasu: All pull requests linked via external trackers have merged: Bugzilla bug 2037483 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
CBO should be able to list the Pods running in the openshift-machine-api namespace to determine the Pod's IP to create the i-c-c deployment. Also, removing CBO's cluster wide permissions to get and list Pods.