Make ProvisioningNetwork values an enum#19
Make ProvisioningNetwork values an enum#19openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
approved
api/v1alpha1/provisioning_types.go
Outdated
| type ProvisioningNetwork string | ||
|
|
||
| const ( | ||
| provisioningNetworkManaged = "Managed" |
There was a problem hiding this comment.
These consts can be defined as being of the new type. I think if you do that, you don't need line 25.
There was a problem hiding this comment.
I removed these constants from the latest changes because they are not necessary to generate the right yaml file. Will add them as part of the validation code that is in review.
| - Managed | ||
| - Unmanaged | ||
| - Disabled | ||
| type: string |
There was a problem hiding this comment.
Making the change in #19 (comment) made these changes in 46 - 49 disappear.
| // the external network that would be used for provisioning services. | ||
| ProvisioningNetwork string `json:"provisioningNetwork,omitempty"` | ||
| ProvisioningNetwork ProvisioningNetwork `json:"provisioningNetwork,omitempty"` | ||
| } |
There was a problem hiding this comment.
Here the type of ProvisioningNetwork has changed but in the resulting yaml file it is still a string.
sadasu
force-pushed
the
provisioning-network-enum
branch
from
d1b0747 to
b1647cf
Compare
sadasu
force-pushed
the
provisioning-network-enum
branch
from
b1647cf to
640297f
Compare
|
Rebased over @asalkeld 's changes. Matches MAO https://github.com/openshift/machine-api-operator/blob/master/install/0000_30_machine-api-operator_04_metal3provisioning.crd.yaml, afaik. |
|
/cc @asalkeld |
|
/retest |
| // +kubebuilder:object:root=true | ||
| // +kubebuilder:resource:path=provisionings,scope=Cluster | ||
| // +kubebuilder:subresource:status | ||
|
|
There was a problem hiding this comment.
any reason for moving these back up?
There was a problem hiding this comment.
Moving this back did not affect
.This change was needed for the yaml file to have https://github.com/openshift/machine-api-operator/blob/master/install/0000_30_machine-api-operator_04_metal3provisioning.crd.yaml#L17-L24.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asalkeld, sadasu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 participants
No description provided.