Skip to content

Add POD_NAMESPACE env variable to bmo container#107

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
asalkeld:support-metal3-pod-namespace
Feb 19, 2021
Merged

Add POD_NAMESPACE env variable to bmo container#107
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
asalkeld:support-metal3-pod-namespace

Conversation

@asalkeld
Copy link
Copy Markdown
Contributor

@asalkeld asalkeld commented Feb 18, 2021

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2021
@asalkeld asalkeld mentioned this pull request Feb 18, 2021
Merged
kirankt
kirankt approved these changes Feb 18, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@kirankt kirankt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2021
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asalkeld, kirankt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Feb 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Feb 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Feb 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Feb 18, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@sadasu sadasu mentioned this pull request Feb 18, 2021
Merged
@asalkeld
Copy link
Copy Markdown
Contributor Author

asalkeld commented Feb 18, 2021

/retest

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Feb 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Feb 19, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit c5bb074 into openshift:master Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhellmann dhellmann Awaiting requested review from dhellmann

@zaneb zaneb Awaiting requested review from zaneb

1 more reviewer

@kirankt kirankt kirankt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kirankt kirankt

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@asalkeld @openshift-ci-robot @openshift-bot @kirankt @openshift-merge-robot