Skip to content

Library go bump#235

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
eggfoobar:library_go_bump
Dec 16, 2021
Merged

Library go bump#235
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
eggfoobar:library_go_bump

Conversation

@eggfoobar
Copy link
Copy Markdown
Contributor

Bumping the library-go dependency to latest, this should take advantage of leader election changes for SNO clusters proposed in this library-go PR and performance improvements in this PR.

Changes:

  • updated library-go to latest
  • added logic to fetch default leader election configs from library-go

Signed-off-by: ehila <ehila@redhat.com>
leader election configs are now coming from conventions in library-go and is topology aware

Signed-off-by: ehila <ehila@redhat.com>
@openshift-ci openshift-ci Bot requested review from Fedosin and JoelSpeed December 16, 2021 05:55
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 16, 2021

@eggfoobar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws b8580b9 link true /test e2e-aws
ci/prow/e2e-upgrade b8580b9 link true /test e2e-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Copy Markdown
Contributor

/approve
/retest-required

This makes sense to me, will this change be implemented across the board now?

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2021
@damdo
Copy link
Copy Markdown
Member

damdo commented Dec 16, 2021

Thanks!
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2021
@openshift-merge-robot openshift-merge-robot merged commit 039ba3e into openshift:master Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants