Bug 1988032: add cvo ha annotation to tombstones

[elmiko]

This change adds the annotation
include.release.openshift.io/self-managed-high-availability: "true"
to the tombstones. This is needed to ensure that the CVO will process
them.

[openshift-ci]

@elmiko: This pull request references Bugzilla bug 1988032, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

Details

In response to this:

Bug 1988032: add cvo ha annotation to tombstones

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jottofar]

e2e-aws is getting:

E0729 18:21:05.029763 1 task.go:112] error running apply for prometheusrule "openshift-machine-api/cluster-autoscaler-operator-rules" (286 of 719): failed to get resource type: no matches for kind "PrometheusRule" in version "monitoring.coreos.com"

No version on apiVersion is perhaps the issue:

apiVersion: monitoring.coreos.com

[elmiko]

as i understand it, this type was removed in 4.7, is there some other way i should be specifying this?

re: https://issues.redhat.com/browse/OCPCLOUD-1153 for reference on the apiVersion

[elmiko]

hmm, so looking back through the historical versions of the MAO repo, i am not seeing the original file which created this object. perhaps we have an error in trying to delete this?

[elmiko]

ok, i think i see the error. the version should be monitoring.coreos.com/v1, according to this file where it was originally created https://github.com/openshift/cluster-autoscaler-operator/blob/release-4.3/install/09_alertrules.yaml

[jottofar]

Maybe I misunderstand your comment but I think your manifests should specify:
apiVersion: monitoring.coreos.com/v1

That is I think it's complaining because you are not specifying /v1.
I'm running a 4.8 cluster and CVO is sync'ing other manifests with that apiVersion just fine.

The manifest from release 4.7.17 that I based the bug on is 0000_50_cluster-autoscaler-operator_09_alertrules.yaml

[elmiko]

thanks for the confirmation @jottofar , updated to correct the apiVersion

[Fedosin]

/lgtm

[Fedosin]

/retest-required

[JoelSpeed]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@elmiko: Some pull requests linked via external trackers have merged:

• openshift/cluster-autoscaler-operator#216

The following pull requests linked via external trackers have not merged:

• openshift/machine-api-operator#893 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1988032 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1988032: add cvo ha annotation to tombstones

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.