Skip to content

Bug 1960554: manifests: use v1 for RBAC#205

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
vrutkovs:rbacv1beta1
May 17, 2021
Merged

Bug 1960554: manifests: use v1 for RBAC#205
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
vrutkovs:rbacv1beta1

Conversation

@vrutkovs
Copy link

rbac v1beta1 support was removed from CVO, so autoscaler should use v1 RBAC

rbac v1beta1 support would be soon removed from CVO
@vrutkovs vrutkovs changed the title manifests: use v1 for RBAC Bug 1960554: manifests: use v1 for RBAC May 17, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label May 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2021

@vrutkovs: This pull request references Bugzilla bug 1960554, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (yanyang@redhat.com), skipping review request.

Details

In response to this:

Bug 1960554: manifests: use v1 for RBAC

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 17, 2021
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Vadim!
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2021
@vrutkovs
Copy link
Author

/cherrypick release-4.7
/retest

@openshift-cherrypick-robot

@vrutkovs: once the present PR merges, I will cherry-pick it on top of release-4.7 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-4.7
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member

wking commented May 17, 2021

I'm going to assume @elmiko wasn't waiting on someone else on the autoscaler side, and LGTM this myself ;)

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2021
@elmiko
Copy link
Contributor

elmiko commented May 17, 2021

i wasn't, just wanted to get an extra set of eyes on this. thanks @wking !

@openshift-merge-robot openshift-merge-robot merged commit 67711a7 into openshift:master May 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2021

@vrutkovs: All pull requests linked via external trackers have merged:

Bugzilla bug 1960554 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1960554: manifests: use v1 for RBAC

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@vrutkovs: new pull request created: #206

Details

In response to this:

/cherrypick release-4.7
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants