Skip to content

Bug 1876469: Update generated CRDs#178

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
JoelSpeed:update-generation
Oct 31, 2020
Merged

Bug 1876469: Update generated CRDs#178
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
JoelSpeed:update-generation

Conversation

@JoelSpeed
Copy link
Contributor

@JoelSpeed JoelSpeed commented Oct 26, 2020

This ensures that CRD generation is up to date and that newer links are included in descriptions for core typemeta/metadata fields

@JoelSpeed
Update generated CRDs
41cd42c 
This ensures that CRD generation is up to date and that newer links are 
included in descriptions for core typemeta/metadata fields
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 26, 2020

@JoelSpeed: This pull request references Bugzilla bug 1876469, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1876469: Update generated CRDs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 26, 2020
@Danil-Grigorev
Copy link

Danil-Grigorev commented Oct 26, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2020
@openshift-ci-robot openshift-ci-robot mentioned this pull request Oct 26, 2020
Merged
@JoelSpeed
Copy link
Contributor Author

JoelSpeed commented Oct 30, 2020

/retest

1 similar comment
@JoelSpeed
Copy link
Contributor Author

JoelSpeed commented Oct 30, 2020

/retest

michaelgugino
michaelgugino approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@michaelgugino michaelgugino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 30, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelgugino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 30, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@michaelgugino
Copy link
Contributor

michaelgugino commented Oct 30, 2020

Spot instance failure. Also, seems we have 3 spot instance machines in our testing machineset. Is it necessary to test wit 3? That might be added unneeded time and resource usage here.

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-autoscaler-operator/178/pull-ci-openshift-cluster-autoscaler-operator-master-e2e-aws-operator/1322144682104328192

@JoelSpeed
Copy link
Contributor Author

JoelSpeed commented Oct 30, 2020

Not particularly necessary no, I'm trying to tackle a bit of the flakiness of that test in openshift/cluster-api-actuator-pkg#193

Currently we spin up 3x3 machines, this PR makes that 1x3 which should in theory make things a bit better, WDYT?

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 30, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 30, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 30, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 30, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 31, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 49f4d05 into openshift:master Oct 31, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 31, 2020

@JoelSpeed: All pull requests linked via external trackers have merged:

Bugzilla bug 1876469 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1876469: Update generated CRDs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexander-demicev alexander-demicev Awaiting requested review from alexander-demicev

@enxebre enxebre Awaiting requested review from enxebre

1 more reviewer

@michaelgugino michaelgugino michaelgugino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Danil-Grigorev Danil-Grigorev

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JoelSpeed @openshift-ci-robot @Danil-Grigorev @openshift-bot @michaelgugino @openshift-merge-robot