OCPBUGS-3441: Update cluster-authentication-operator not to go degraded without console [4.13] #587

bparees · 2022-10-28T21:14:37Z

No description provided.

bparees · 2022-11-07T22:20:03Z

/retest-required

bparees · 2022-11-08T14:27:08Z

/retest-required

stlaz · 2022-11-08T18:41:24Z

pkg/controllers/configobservation/configobservercontroller/observe_config_controller.go

+
+	// Check if the Console capability is enabled on the cluster and sync and add its informer and lister.
+	if enabledClusterCapabilities.Has("Console") {
+		preRunCacheSynced = append(preRunCacheSynced, configInformer.Config().V1().Consoles().Informer().HasSynced)


I think this should be listers.PreRunCachesSynced = append(listers.PreRunCachesSynced, ... to make sure the above struct contains the right slice

…ed without console

stlaz · 2022-11-08T18:48:57Z

/lgtm

bparees · 2022-11-08T18:49:35Z

/hold cancel

bparees · 2022-11-08T18:49:57Z

/cherry-pick release-4.12

openshift-cherrypick-robot · 2022-11-08T18:49:59Z

@bparees: once the present PR merges, I will cherry-pick it on top of release-4.12 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-11-08T18:50:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [stlaz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2022-11-08T21:50:42Z

@bparees: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-agnostic-ipv6	`dbf8200`	link	false	`/test e2e-agnostic-ipv6`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2022-11-09T14:32:36Z

@bparees: This pull request references Jira Issue OCPBUGS-3441, which is invalid:

expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bparees · 2022-11-09T14:52:55Z

/jira refresh

openshift-ci-robot · 2022-11-09T14:52:58Z

@bparees: This pull request references Jira Issue OCPBUGS-3441, which is invalid:

expected the bug to target the "4.13.0" version, but it targets "4.13" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bparees · 2022-11-09T14:53:22Z

/jira refresh

openshift-ci-robot · 2022-11-09T14:53:31Z

@bparees: This pull request references Jira Issue OCPBUGS-3441, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.0) matches configured target version for branch (4.13.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bparees · 2022-11-10T15:53:27Z

/retest-required

openshift-ci-robot · 2022-11-10T18:36:16Z

@bparees: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

openshift/cluster-authentication-operator#583 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-3441 has not been moved to the MODIFIED state.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2022-11-10T18:37:07Z

@bparees: new pull request created: #590

Details

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jhadvig · 2022-11-11T11:39:15Z

🥳

bparees added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2022

openshift-ci bot requested review from stlaz and sttts October 28, 2022 21:15

bparees changed the title ~~CONSOLE-3322: Update cluster-authentication-operator not to go degraded without console~~ [4.13] CONSOLE-3322: Update cluster-authentication-operator not to go degraded without console Oct 28, 2022

bparees force-pushed the nocache branch 3 times, most recently from 1d52991 to 881a105 Compare November 4, 2022 21:05

bparees force-pushed the nocache branch from 881a105 to 50350ce Compare November 7, 2022 18:46

stlaz suggested changes Nov 8, 2022

View reviewed changes

CONSOLE-3322: Update cluster-authentication-operator not to go degrad…

dbf8200

…ed without console

bparees force-pushed the nocache branch from 50350ce to dbf8200 Compare November 8, 2022 18:48

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2022

openshift-ci bot assigned stlaz Nov 8, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2022

bparees changed the title ~~[4.13] CONSOLE-3322: Update cluster-authentication-operator not to go degraded without console~~ CONSOLE-3322: Update cluster-authentication-operator not to go degraded without console [4.13] Nov 9, 2022

bparees changed the title ~~CONSOLE-3322: Update cluster-authentication-operator not to go degraded without console [4.13]~~ AUTH-319: Update cluster-authentication-operator not to go degraded without console [4.13] Nov 9, 2022

bparees changed the title ~~AUTH-319: Update cluster-authentication-operator not to go degraded without console [4.13]~~ OCPBUGS-3441: Update cluster-authentication-operator not to go degraded without console [4.13] Nov 9, 2022

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 9, 2022

openshift-merge-robot merged commit a9b053e into openshift:master Nov 10, 2022

openshift-cherrypick-robot mentioned this pull request Nov 10, 2022

[release-4.12] OCPBUGS-3510: Update cluster-authentication-operator not to go degraded without console #590

Merged

jhadvig mentioned this pull request Nov 11, 2022

CONSOLE-3322: Update cluster-authentication-operator not to go degraded without console #583

Closed

OCPBUGS-3441: Update cluster-authentication-operator not to go degraded without console [4.13] #587

OCPBUGS-3441: Update cluster-authentication-operator not to go degraded without console [4.13] #587

Uh oh!

Conversation

bparees commented Oct 28, 2022

Uh oh!

bparees commented Nov 7, 2022

Uh oh!

bparees commented Nov 8, 2022

Uh oh!

stlaz Nov 8, 2022

Choose a reason for hiding this comment

Uh oh!

stlaz commented Nov 8, 2022

Uh oh!

bparees commented Nov 8, 2022

Uh oh!

bparees commented Nov 8, 2022

Uh oh!

openshift-cherrypick-robot commented Nov 8, 2022

Uh oh!

openshift-ci bot commented Nov 8, 2022

Uh oh!

openshift-ci bot commented Nov 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 9, 2022

Uh oh!

bparees commented Nov 9, 2022

Uh oh!

openshift-ci-robot commented Nov 9, 2022

Uh oh!

bparees commented Nov 9, 2022

Uh oh!

openshift-ci-robot commented Nov 9, 2022

Uh oh!

bparees commented Nov 10, 2022

Uh oh!

openshift-ci-robot commented Nov 10, 2022

Uh oh!

openshift-cherrypick-robot commented Nov 10, 2022

Uh oh!

jhadvig commented Nov 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

openshift-ci bot commented Nov 8, 2022 •

edited

Loading