Skip to content

Comments

Bug 2041554: bump library go#537

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
EmilyM1:lib-go-managed-fields
Jan 19, 2022
Merged

Bug 2041554: bump library go#537
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
EmilyM1:lib-go-managed-fields

Conversation

@EmilyM1
Copy link
Contributor

@EmilyM1 EmilyM1 commented Jan 17, 2022

Library go bump to delete managed fields

@openshift-ci openshift-ci bot requested review from deads2k and stlaz January 17, 2022 21:08
@EmilyM1
Copy link
Contributor Author

EmilyM1 commented Jan 18, 2022

/retest

@stlaz
Copy link
Contributor

stlaz commented Jan 18, 2022

What's the related lib-go change?

@tkashem
Copy link
Contributor

tkashem commented Jan 18, 2022

What's the related lib-go change?

two changes:

  • leader election changes we are rolling out across all operators
  • and the new audit API change for managed fields.

@tkashem
Copy link
Contributor

tkashem commented Jan 18, 2022

LGTM

will give others a chance to review

@tkashem
Copy link
Contributor

tkashem commented Jan 18, 2022

@Emily_Moss you can use either of these two BZs (or clone) for your PR to have a valid bug label:

@EmilyM1 EmilyM1 changed the title bump library go bug 2041541: bump library go Jan 18, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 18, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 18, 2022

@EmilyM1: This pull request references Bugzilla bug 2041541, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

bug 2041541: bump library go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@EmilyM1
Copy link
Contributor Author

EmilyM1 commented Jan 18, 2022

/test e2e-agnostic-upgrade

@EmilyM1 EmilyM1 changed the title bug 2041541: bump library go bug 2042038: bump library go Jan 18, 2022
@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 18, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 18, 2022

@EmilyM1: This pull request references Bugzilla bug 2042038, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @xingxingxia

Details

In response to this:

bug 2042038: bump library go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from xingxingxia January 18, 2022 17:59
@EmilyM1
Copy link
Contributor Author

EmilyM1 commented Jan 18, 2022

/test e2e-agnostic-upgrade

@tkashem
Copy link
Contributor

tkashem commented Jan 18, 2022

/retest

@stlaz
Copy link
Contributor

stlaz commented Jan 19, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilyM1, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2022

@EmilyM1: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit fe4ead9 into openshift:master Jan 19, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2022

@EmilyM1: All pull requests linked via external trackers have merged:

Bugzilla bug 2042038 has been moved to the MODIFIED state.

Details

In response to this:

bug 2042038: bump library go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@s-urbaniak s-urbaniak changed the title bug 2042038: bump library go Bug 2041554: bump library go Jan 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 21, 2022

@EmilyM1: Bugzilla bug 2041554 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

Details

In response to this:

Bug 2041554: bump library go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants