Annotate manifests for single-node-developer cluster profile #383

guillaumerose · 2020-11-26T14:39:11Z

This implements phase 1 of openshift/enhancements#482

rkukura · 2020-11-30T22:10:42Z

Do the manifests under vendor/github.com/openshift/api also need to be updated to pickup the profile annotations?

stlaz · 2020-12-01T14:24:37Z

Please explain in details of what the annotation actually does in the commit message, link to an enhancement won't do for anyone who wants to quickly understand why the annotation's there.

I haven't read the enhancement and I do not know the consequences of this annotation. Single-node cluster sounds contradictive. Does that mean the operator's code will need to change? Who is going to implement the necessary changes?

stlaz · 2020-12-01T14:25:54Z

/hold

This partially implements phase 1 of openshift/enhancements#482 and does not change behavior. Initially, all manifests are included in the single-node-developer cluster profile. Follow-on PRs may exclude any of these that are not needed in the profile.

guillaumerose · 2020-12-02T08:29:01Z

I updated the commit message.

In a future release, cluster profile will be used to determine which manifests will be applied by the CVO. The default profile is self-managed-high-availability.
CRC will use a new one, single-node-developer and edge production cluster single-node-production.

Does that mean the operator's code will need to change?

Yes. Right now, we don't modify operators but in the future we might have to open PRs to fine tune operators for our profile.
For this operator, a good thing for us would be to customize https://github.com/openshift/cluster-authentication-operator/blob/master/manifests/02_config.cr.yaml and directly include useUnsupportedUnsafeNonHANonProductionUnstableOAuthServer.

Who is going to implement the necessary changes?

Teams that need it. For the single-node-developer profile, CRC team.

stlaz · 2020-12-02T09:31:56Z

/hold cancel

Who is going to implement the necessary changes?

Teams that need it. For the single-node-developer profile, CRC team.

I'm taking your word for it, then ;)

stlaz · 2020-12-02T09:32:14Z

/lgtm

openshift-ci-robot · 2020-12-02T09:32:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guillaumerose, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [stlaz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-12-02T10:31:20Z

/retest