Skip to content

Bug 1874056: bump library-go #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Sep 15, 2020
Merged

Bug 1874056: bump library-go #346

openshift-merge-robot merged 2 commits into from
Sep 15, 2020

Conversation

@mfojtik
Copy link
Contributor

@mfojtik mfojtik commented Sep 15, 2020

No description provided.

@deads2k
Copy link
Contributor

deads2k commented Sep 15, 2020

/lgtm

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 15, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 15, 2020
@mfojtik mfojtik changed the title Bump library-go Bug 1874056: bump library-go Sep 15, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 15, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 15, 2020

@mfojtik: This pull request references Bugzilla bug 1874056, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1874056: bump library-go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sttts
sttts reviewed Sep 15, 2020
View reviewed changes
@mfojtik
bump(*): vendor update
e2a3f64 
* openshift/library-go@29b87426: Validate operatorSpec.logLevel
* openshift/library-go@60c31b99: installer: do not log stacktrace when installer pod fail
* openshift/library-go@4c0f9d62: installer: log connection errors on retry
* openshift/library-go@206b1e87: installer: add reason with blame
* openshift/library-go@1b6a6521: Bug 1876913: Redact proxy urls in git config
* openshift/library-go@7c3376dd: controller factory: implement interesting NS queue adds via filters
* openshift/library-go@2cd1cff3: controller factory: add informers with filtered events
* openshift/library-go@dc7ecd85: Fix panic in cache sync
* openshift/library-go@17d1c97b: use upstream sigs.k8s.io/kube-storage-version-migrator
* openshift/library-go@cc75ddff: go mod vendor
* openshift/library-go@76e9b240: apiserver-audit: add secure-oauth-storage-* policies
@mfojtik
starter: move kube migrator
256a5f7
@mfojtik mfojtik force-pushed the bump-library-go-factory branch from 87a2d64 to 256a5f7 Compare September 15, 2020 13:50
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 15, 2020

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2020
@mfojtik mfojtik added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 15, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 15, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 15, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6ac342c into openshift:master Sep 15, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 15, 2020

@mfojtik: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1874056 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1874056: bump library-go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stlaz stlaz Awaiting requested review from stlaz

1 more reviewer

@sttts sttts sttts left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mfojtik @deads2k @openshift-ci-robot @openshift-bot @sttts @openshift-merge-robot