Skip to content

Bug 1776421: Add manifest annotations for hosted deployment exclusions (4.3)#221

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.3from
csrwng:hosted_exclusions_43
Nov 27, 2019
Merged

Bug 1776421: Add manifest annotations for hosted deployment exclusions (4.3)#221
openshift-merge-robot merged 1 commit intoopenshift:release-4.3from
csrwng:hosted_exclusions_43

Conversation

@csrwng
Copy link
Copy Markdown
Contributor

@csrwng csrwng commented Nov 26, 2019

Enables the CVO to exclude manifests in an externally hosted control plane deployment
See openshift/cluster-version-operator#252

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@csrwng: This pull request references Bugzilla bug 1776421, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "4.4.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1776421: Add manifest annotations for hosted deployment exclusions (4.3)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 26, 2019
@csrwng
Copy link
Copy Markdown
Contributor Author

csrwng commented Nov 26, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@csrwng: This pull request references Bugzilla bug 1776421, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "4.4.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csrwng
Copy link
Copy Markdown
Contributor Author

csrwng commented Nov 26, 2019

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 26, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@csrwng: This pull request references Bugzilla bug 1776421, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 26, 2019
@csrwng
Copy link
Copy Markdown
Contributor Author

csrwng commented Nov 26, 2019

/retest
/assign @stlaz

@stlaz
Copy link
Copy Markdown
Contributor

stlaz commented Nov 26, 2019

this is a backport of #220

@stlaz
Copy link
Copy Markdown
Contributor

stlaz commented Nov 27, 2019

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2019
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 046115b into openshift:release-4.3 Nov 27, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@csrwng: All pull requests linked via external trackers have merged. Bugzilla bug 1776421 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1776421: Add manifest annotations for hosted deployment exclusions (4.3)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants