-
Notifications
You must be signed in to change notification settings - Fork 25
OCPBUGS-55947: Regenerate manifests to drop v1beta1 admissionregistration usage #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-55947: Regenerate manifests to drop v1beta1 admissionregistration usage #236
Conversation
|
@JoelSpeed: This pull request references Jira Issue OCPBUGS-55947, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
damdo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
|
/unlgtm You'll need the carry/drop title |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damdo, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f9ca42e to
4f8730c
Compare
4f8730c to
9477faf
Compare
damdo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
@JoelSpeed: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@JoelSpeed: Jira Issue OCPBUGS-55947: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-55947 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-api |
|
Only missing the manual backport here, we can use this version of the manifests-gen openshift/cluster-capi-operator#291 |
We should be using the v1 API group and not v1beta1, this updates the manifests-gen dependency and drops usage of the v1beta1 API group