Upstream: <880>: openshift: Record machine sync error event#23
Upstream: <880>: openshift: Record machine sync error event#23vikaschoudhary16 wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/hold |
|
Is there a counter part PR for upstream? Do you want to move the this PR against |
ea6a146 to
e507062
Compare
|
@vikaschoudhary16: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
moved to #24 |
What this PR does / why we need it:
Fixes the recording of machine sync errors. Currently if machineset faces any error which reconciling machines, this error will not be reported at machineset object.
This PR fixes above issue.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1696407
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: