Skip to content

Comments

Upstream: <880>: openshift: Record machine sync error event#23

Closed
vikaschoudhary16 wants to merge 1 commit intoopenshift:masterfrom
vikaschoudhary16:syncerrms
Closed

Upstream: <880>: openshift: Record machine sync error event#23
vikaschoudhary16 wants to merge 1 commit intoopenshift:masterfrom
vikaschoudhary16:syncerrms

Conversation

@vikaschoudhary16
Copy link

What this PR does / why we need it:
Fixes the recording of machine sync errors. Currently if machineset faces any error which reconciling machines, this error will not be reported at machineset object.

This PR fixes above issue.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1696407

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 8, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: vikaschoudhary16

If they are not already assigned, you can assign the PR to them by writing /assign @vikaschoudhary16 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@enxebre
Copy link
Member

enxebre commented Apr 8, 2019

/hold
please reword commit message: Upstream: <carry>/PR: openshift: message

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 8, 2019
@enxebre
Copy link
Member

enxebre commented Apr 8, 2019

Is there a counter part PR for upstream?

Do you want to move the this PR against openshift-4.0-cluster-api-0.0.0-alpha.4? That branch is the source of truth containing latest changes atm

@vikaschoudhary16 vikaschoudhary16 changed the title Record machine sync error event Upstream: <880>: openshift: Record machine sync error event Apr 8, 2019
@openshift-ci-robot
Copy link

@vikaschoudhary16: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/git-history e507062 link /test git-history

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vikaschoudhary16
Copy link
Author

moved to #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants