Skip to content

OCPBUGS-29519: openshift: add CustomNoUpgrade annotation value to feature-set#196

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
damdo:openshift-fix-feature-setannotations
Feb 15, 2024
Merged

OCPBUGS-29519: openshift: add CustomNoUpgrade annotation value to feature-set#196
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
damdo:openshift-fix-feature-setannotations

Conversation

@damdo
Copy link
Member

@damdo damdo commented Feb 15, 2024

Together with the TechPreviewNoUpgrade release.openshift.io/feature-set we also need to add CustomNoUpgrade as that is used in certain scenarios where CAPI provider ConfigMaps and CRDs are required.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Feb 15, 2024
@openshift-ci-robot
Copy link

@damdo: This pull request references Jira Issue OCPBUGS-29519, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Together with the TechPreviewNoUpgrade release.openshift.io/feature-set we also need to add CustomNoUpgrade as that is used in certain scenarios where CAPI provider ConfigMaps and CRDs are required.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sunzhaohua2 February 15, 2024 15:05
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 15, 2024
@openshift-ci
Copy link

openshift-ci bot commented Feb 15, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2024
@damdo damdo force-pushed the openshift-fix-feature-setannotations branch from 5ba65e3 to a0a1c10 Compare February 15, 2024 15:35
@damdo damdo marked this pull request as ready for review February 15, 2024 15:36
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 15, 2024
@JoelSpeed
Copy link

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2024
@openshift-ci
Copy link

openshift-ci bot commented Feb 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1892065 and 2 for PR HEAD a0a1c10 in total

@damdo
Copy link
Member Author

damdo commented Feb 15, 2024

/retest

@openshift-ci
Copy link

openshift-ci bot commented Feb 15, 2024

@damdo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 207bba7 into openshift:master Feb 15, 2024
@openshift-ci-robot
Copy link

@damdo: Jira Issue OCPBUGS-29519: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29519 has been moved to the MODIFIED state.

Details

In response to this:

Together with the TechPreviewNoUpgrade release.openshift.io/feature-set we also need to add CustomNoUpgrade as that is used in certain scenarios where CAPI provider ConfigMaps and CRDs are required.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-api-container-v4.16.0-202402152340.p0.g207bba7.assembly.stream.el9 for distgit ose-cluster-api.
All builds following this will include this PR.

@openshift-merge-robot
Copy link

Fix included in accepted release 4.16.0-0.nightly-2024-02-17-013806

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments