Skip to content

API types and basic controller/actuator scaffolding#2

Closed
detiber wants to merge 1 commit intoopenshift:masterfrom
detiber:metal-api
Closed

API types and basic controller/actuator scaffolding#2
detiber wants to merge 1 commit intoopenshift:masterfrom
detiber:metal-api

Conversation

@detiber
Copy link
Copy Markdown

@detiber detiber commented Oct 14, 2020

Adds the initial basic API types and minimal scaffolding for the controller/actuators.

@detiber
Copy link
Copy Markdown
Author

detiber commented Oct 14, 2020

/cc @displague

@openshift-ci-robot
Copy link
Copy Markdown

@detiber: GitHub didn't allow me to request PR reviews from the following users: displague.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @displague

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Copy Markdown

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the openshift org. You can then trigger verification by writing /verify-owners in a comment.

  • displague
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • detiber
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Oct 14, 2020
Copy link
Copy Markdown

@displague displague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm mainly interested in the starting point that this PR provides for the Equinix Metal provider types that will be used by openshift/installer#3914.

https://github.com/openshift/cluster-api-provider-packet/pull/2/files#diff-842042708803b07649ebe3065dcd5adcf03fdbe36b289817840a4c27aab2c722R15-R27

This is a sufficient starting point upon which we can build.

Comment thread go.mod
Comment thread Dockerfile
@@ -0,0 +1,9 @@
FROM registry.svc.ci.openshift.org/ocp/builder:rhel-8-golang-openshift-4.6 AS builder
WORKDIR /go/src/github.com/openshift/cluster-api-provider-packet
Copy link
Copy Markdown

@displague displague Oct 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who can help us rename this project to cluster-api-provider-equinix-metal? (or unhyphenated equinixmetal, I don't know if there is a preference for technical or historical reasons)

@detiber
Copy link
Copy Markdown
Author

detiber commented Nov 13, 2020

Closing this in favor of #1

@detiber detiber closed this Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants