Add ServerGroupID to OpenstackProviderSpec #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierreprinetti
requested review from
Fedosin,
adduarte,
iamemilio and
mandre
openshift-ci-robot
added
approved
With this change, it is possible to pass an OpenStack Server Group[1] in the machine configuration, so that the machine will be assigned to it. Prerequisite for OSASINFRA-1300 (soft-anti-affinity) [1]: https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/server-group.html
pierreprinetti
force-pushed
the
OSASINFRA-1300
branch
from
8a394b8 to
015dce0
Compare
openshift-ci-robot
added
size/L
Member
Author
|
/retest |
Member
Author
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
Member
Author
|
/hold cancel |
Member
Author
|
/retest |
openshift-ci-robot
removed
the
do-not-merge/hold
Member
Author
|
/test e2e-openstack |
|
/lgtm Feel free to remove the hold once the |
openshift-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierreprinetti, tomassedovic The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/test e2e-openstack |
6 similar comments
Member
Author
|
/test e2e-openstack |
Member
Author
|
/test e2e-openstack |
Member
Author
|
/test e2e-openstack |
Member
Author
|
/test e2e-openstack |
Member
Author
|
/test e2e-openstack |
Member
Author
|
/test e2e-openstack |
Member
|
/test e2e-openstack |
Member
Author
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
pierreprinetti
pushed a commit
to shiftstack/cluster-api-provider-openstack
that referenced
this pull request
Apr 22, 2024
Refactor generate-yaml.sh to allow for generating templates for multiple OSs. I consider generate-yaml.sh a temporary script that we're using to ease development and not a production ready tool. Eventually it should go away/moved to avoid sending the wrong message as far as these examples go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, it is possible to pass an OpenStack Server Group1 in
the machine configuration, so that the machine will be assigned to it.
Prerequisite for OSASINFRA-1300 (soft-anti-affinity)