Skip to content

[release-4.3] Bug 1796822: Support deployment on OpenStack with self-signed certificate #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Feb 4, 2020
Merged

[release-4.3] Bug 1796822: Support deployment on OpenStack with self-signed certificate #81

openshift-merge-robot merged 2 commits into from
Feb 4, 2020

Conversation

@mandre
Copy link
Member

@mandre mandre commented Jan 31, 2020

This is a backport of #79 and #80

Emilio Garcia and others added 2 commits January 31, 2020 17:37
@mandre
get ca cert from cloud-provider-config
1bf8ca6 
It's a valid use case, for instance when deploying on an OpenStack
cloud that doesn't use SSL.
@mandre
Bug 1795035: Give reason for not using cloud provider CA cert
8be7097 
This makes it easier to debug in case CAPO can't read the CA cert from
the `openshift-config/cloud-provider-config` configmap.
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 31, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 31, 2020

@mandre: This pull request references Bugzilla bug 1796822, which is invalid:

  • expected dependent Bugzilla bug 1788072 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1796822: Support deployment on OpenStack with self-signed certificate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 31, 2020
@mandre
Copy link
Member Author

mandre commented Jan 31, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 31, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 31, 2020

@mandre: This pull request references Bugzilla bug 1796822, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre mandre changed the title Bug 1796822: Support deployment on OpenStack with self-signed certificate [release-4.3] Bug 1796822: Support deployment on OpenStack with self-signed certificate Jan 31, 2020
@iamemilio
Copy link

iamemilio commented Jan 31, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 31, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamemilio, mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson sdodson added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Feb 3, 2020
@eparis eparis added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 4, 2020
@openshift-bot
Copy link

openshift-bot commented Feb 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 7aa99e2 into openshift:release-4.3 Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamemilio iamemilio Awaiting requested review from iamemilio

@tomassedovic tomassedovic Awaiting requested review from tomassedovic

Assignees

@iamemilio iamemilio

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mandre @openshift-ci-robot @iamemilio @openshift-bot @sdodson @eparis @openshift-merge-robot