Bug 1746015: provide correct API to machine serialization #61
Conversation
|
@Fedosin: This pull request references Bugzilla bug 1746015, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
openshift-ci-robot
added
approved
Fedosin
force-pushed
the
delete_machine
branch
from
8f20e18 to
5eb6a28
Compare
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
@Fedosin: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fedosin
force-pushed
the
delete_machine
branch
from
5eb6a28 to
5dfb879
Compare
|
@Fedosin: This pull request references Bugzilla bug 1746015, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/test e2e-openstack |
1 similar comment
|
/test e2e-openstack |
Now we use k8s API to create a mahine that later will be deleted, but since this API is not registered in OpenShift we have an empty struct as a result. Later actuator will parse the providerSpec of the machine and fail because it cannot be found. This patch changes the API correct "machine.openshift.io"
Fedosin
force-pushed
the
delete_machine
branch
from
5dfb879 to
926f159
Compare
Fedosin
changed the title
|
@Fedosin: This pull request references Bugzilla bug 1746015, which is valid. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
much better now :) I don't see those errors in the log now |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fedosin, mandre The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
@Fedosin: All pull requests linked via external trackers have merged. Bugzilla bug 1746015 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This patch adds kuryr support by ensuring that VMs can be created on top of trunk ports if kuryr is enabled.
This reverts commit 9e7a9ce.
This reverts commit 1ca3d81. Problem was cluster-api-provider-openstack vendor was wrongly added
This patch adds kuryr support by ensuring that VMs can be created on top of trunk ports if kuryr is enabled.
This reverts commit 9e7a9ce.
This reverts commit 1ca3d81. Problem was cluster-api-provider-openstack vendor was wrongly added
4 participants
Now we use k8s API to create a machine that later will be deleted, but since this API is not registered in OpenShift we have an empty struct as a result.
Later the actuator will parse the providerSpec of the machine and fail because it cannot be found.
This patch changes the API correct "machine.openshift.io"