-
Notifications
You must be signed in to change notification settings - Fork 33
Rename schema group to openshift io #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename schema group to openshift io #53
Conversation
…rconfig.openshift.io All openshift machine types are required to live under .openshift.io group. The same holds for provider configs/specs which are shipped with openshift by default.
|
Given the providerspec is encoded through yaml, installer generated provider spec apiversion is ignored. Thus, the group suffix can be changed in parallel: openshift/installer#2152 |
|
/hold I'm really sorry about this, the OpenStack deployments (including the The fix (openshift/cluster-kube-controller-manager-operator#275) is merged, but we need to wait for a new release image to get created and re-run the e2e test. The change itself looks good to me. |
|
/retest |
|
/hold cancel |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund, tomassedovic The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* update url to cluster-api project * update README to ref minikube 0.30.0 * add go dev-env as prereq in README * fix path for clusterctl fixes kubernetes-sigs#51 * reference project id instead of tenant id Changed to be consistent with the naming in clouds.yaml * use fixed path for SSH key removal xref: kubernetes-sigs#39
* update url to cluster-api project * update README to ref minikube 0.30.0 * add go dev-env as prereq in README * fix path for clusterctl fixes kubernetes-sigs#51 * reference project id instead of tenant id Changed to be consistent with the naming in clouds.yaml * use fixed path for SSH key removal xref: kubernetes-sigs#39
What this PR does / why we need it:
Rename
openstackproviderconfig.k8s.iotoopenstackproviderconfig.openshift.io.All openshift machine types are required to live under .openshift.io group.
The same holds for provider configs/specs which are shipped with openshift by default.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: