Skip to content

Conversation

@ingvagabund
Copy link
Member

What this PR does / why we need it:

Rename openstackproviderconfig.k8s.io to openstackproviderconfig.openshift.io.

All openshift machine types are required to live under .openshift.io group.
The same holds for provider configs/specs which are shipped with openshift by default.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


…rconfig.openshift.io

All openshift machine types are required to live under .openshift.io group.
The same holds for provider configs/specs which are shipped with openshift by default.
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 5, 2019
@ingvagabund
Copy link
Member Author

Given the providerspec is encoded through yaml, installer generated provider spec apiversion is ignored. Thus, the group suffix can be changed in parallel: openshift/installer#2152

@tomassedovic
Copy link

/hold

I'm really sorry about this, the OpenStack deployments (including the e2e-openstack job) have been broken by openshift/library-go#500. I'm putting this on hold to prevent merging before we can fully test it.

The fix (openshift/cluster-kube-controller-manager-operator#275) is merged, but we need to wait for a new release image to get created and re-run the e2e test.

The change itself looks good to me.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2019
@tomassedovic
Copy link

/retest

@tomassedovic
Copy link

/hold cancel
/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 5, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, tomassedovic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2019
@openshift-merge-robot openshift-merge-robot merged commit 076f2c3 into openshift:master Aug 5, 2019
@tomassedovic tomassedovic mentioned this pull request Aug 5, 2019
@ingvagabund ingvagabund deleted the rename-schema-group-to-openshift-io branch August 5, 2019 13:02
racheljpg pushed a commit to racheljpg/cluster-api-provider-openstack that referenced this pull request Dec 20, 2023
* update url to cluster-api project

* update README to ref minikube 0.30.0

* add go dev-env as prereq in README

* fix path for clusterctl
fixes kubernetes-sigs#51

* reference project id instead of tenant id
Changed to be consistent with the naming in clouds.yaml

* use fixed path for SSH key removal
xref: kubernetes-sigs#39
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
* update url to cluster-api project

* update README to ref minikube 0.30.0

* add go dev-env as prereq in README

* fix path for clusterctl
fixes kubernetes-sigs#51

* reference project id instead of tenant id
Changed to be consistent with the naming in clouds.yaml

* use fixed path for SSH key removal
xref: kubernetes-sigs#39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants