Integrating useful changes from upstream #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
openshift-ci-robot
added
the
size/XL
This PR adds ConfigDrive zz_generated.deepcopy.go by executing go generate under pkg/apis and fix Makefile to prevent from missing.
timeout is hard code and sometimes it's might be need to wait for more than 5 min for instance create in some cloud.
This changes provide security groups removal during cluster deletion if managedSecurityGroups is true in clusterSpec.providerSpec Change-Id: I62002e50ae7c60b7fda38663118f8deabb03ba3c
run 'make unit' locally have those update...
we are not providing any info about control pane CA key and pem add those info will be confusing to end user and seems add private key info into the status is not that secure..
openshift-ci-robot
added
size/L
This patch fixes event creation.
make TokenTTL configurable through CLI
trown
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamemilio, trown The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
racheljpg
pushed a commit
to racheljpg/cluster-api-provider-openstack
that referenced
this pull request
Dec 20, 2023
pierreprinetti
pushed a commit
to shiftstack/cluster-api-provider-openstack
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Pulls down changes from upstream that benefit us
This pull request is a little. For now, we are going to merge upstream patches that are useful, or would prevent merge conflicts in the future.