Skip to content

Conversation

@trown
Copy link

@trown trown commented May 24, 2019

We no longer need to build the installer in CAPO e2e jobs.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 24, 2019
@mandre
Copy link
Member

mandre commented May 27, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, trown

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 0bd838b into openshift:master May 27, 2019
racheljpg pushed a commit to racheljpg/cluster-api-provider-openstack that referenced this pull request Dec 20, 2023
* Uses Clouds.yaml to authenticate with openstack

* Use Clouds.yaml

this patch allows clouds.yaml to be used to configure access to the openstack cluster
in response to: kubernetes-sigs#16

* unit tests

* Modifies the generator to genreate clouds.yaml scripts
 - can also read in clouds.yaml files
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
* Uses Clouds.yaml to authenticate with openstack

* Use Clouds.yaml

this patch allows clouds.yaml to be used to configure access to the openstack cluster
in response to: kubernetes-sigs#16

* unit tests

* Modifies the generator to genreate clouds.yaml scripts
 - can also read in clouds.yaml files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants