Skip to content

Conversation

@pierreprinetti
Copy link
Member

a follow up to #377

@openshift-ci openshift-ci bot requested review from gryf and mandre October 9, 2025 12:04
@pierreprinetti
Copy link
Member Author

pierreprinetti commented Oct 9, 2025

This fixes the ci/prow/verify job that is currently blocking e.g. #376 (comment)

@pierreprinetti
Copy link
Member Author

/retest-required

@pierreprinetti pierreprinetti reopened this Oct 9, 2025
@pierreprinetti pierreprinetti changed the title Fix internal vendoring NO-JIRA: Fix internal vendoring Oct 9, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 9, 2025
@openshift-ci-robot
Copy link

@pierreprinetti: This pull request explicitly references no jira issue.

Details

In response to this:

a follow up to #377

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pierreprinetti
Copy link
Member Author

/override ci/prow/e2e-hypershift ci/prow/e2e-techpreview ci/prow/okd-scos-e2e-aws-ovn

@openshift-ci
Copy link

openshift-ci bot commented Oct 9, 2025

@pierreprinetti: Overrode contexts on behalf of pierreprinetti: ci/prow/e2e-hypershift, ci/prow/e2e-techpreview, ci/prow/okd-scos-e2e-aws-ovn

Details

In response to this:

/override ci/prow/e2e-hypershift ci/prow/e2e-techpreview ci/prow/okd-scos-e2e-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link

openshift-ci bot commented Oct 9, 2025

@pierreprinetti: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pierreprinetti
Copy link
Member Author

/verified bypass

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 9, 2025
@openshift-ci-robot
Copy link

@pierreprinetti: The verified label has been added.

Details

In response to this:

/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 3e14954 into openshift:main Oct 10, 2025
11 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the gomod_vendor branch October 10, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants