Skip to content

Conversation

@shiftstack-merge-bot
Copy link

No description provided.

Huy Mai and others added 17 commits January 24, 2025 16:46
Signed-off-by: Lennart Jern <[email protected]>
…ot/cherry-pick-2256-to-release-0.12

[release-0.12] 🐛 Ensure that existing ports also have correct tags and trunks
…es with 1 update

Bumps the all-go-mod-patch-and-minor group with 1 update in the / directory: [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime).
Bumps the all-go-mod-patch-and-minor group with 1 update in the /hack/tools directory: [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime).


Updates `sigs.k8s.io/controller-runtime` from 0.19.4 to 0.19.5
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](kubernetes-sigs/controller-runtime@v0.19.4...v0.19.5)

Updates `sigs.k8s.io/controller-runtime` from 0.19.4 to 0.19.5
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](kubernetes-sigs/controller-runtime@v0.19.4...v0.19.5)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-type: indirect
  update-type: version-update:semver-patch
  dependency-group: all-go-mod-patch-and-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…ot/go_modules/release-0.12/all-go-mod-patch-and-minor-5b7926cd04

🌱(deps): Bump the all-go-mod-patch-and-minor group across 2 directories with 1 update
`InstanceState` was copied to the `OpenStackServer` API and the
`OpenStackMachine` controller doesn't care about this field anymore.
The field still exists for backward compatibility but it was decided
long time ago (when we worked on the `OpenStackServer` API) that it
wouldn't be populated anymore.
We missed to stop printing this field when listing the
`OpenStackMachines`.

Also, we now document that the field is not populated anymore. This was
also a miss.
…ot/cherry-pick-2402-to-release-0.12

[release-0.12] 🐛 Stop printing InstanceState for OpenStackMachine
To support upgrades from 0.10 where the bastion port name was named
after the namespace + cluster name, we need to take care of removing
that port as well during an upgrade.

(cherry picked from commit 2a8c1a8)
[release-0.12] port/cleanup: support old bastion port name
…es with 1 update

Bumps the all-go-mod-patch-and-minor group with 1 update in the / directory: [github.com/spf13/pflag](https://github.com/spf13/pflag).
Bumps the all-go-mod-patch-and-minor group with 1 update in the /hack/tools directory: [github.com/spf13/pflag](https://github.com/spf13/pflag).


Updates `github.com/spf13/pflag` from 1.0.5 to 1.0.6
- [Release notes](https://github.com/spf13/pflag/releases)
- [Commits](spf13/pflag@v1.0.5...v1.0.6)

Updates `github.com/spf13/pflag` from 1.0.5 to 1.0.6
- [Release notes](https://github.com/spf13/pflag/releases)
- [Commits](spf13/pflag@v1.0.5...v1.0.6)

---
updated-dependencies:
- dependency-name: github.com/spf13/pflag
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: github.com/spf13/pflag
  dependency-type: indirect
  update-type: version-update:semver-patch
  dependency-group: all-go-mod-patch-and-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…ot/go_modules/release-0.12/all-go-mod-patch-and-minor-dafd14f470

🌱(deps): Bump the all-go-mod-patch-and-minor group across 2 directories with 1 update
…ot/cherry-pick-2419-to-release-0.12

[release-0.12] 🌱 data: use latest Flatcar stable from image-builder
Specifying the patch version is not needed and can causes problems on
systems which haven't updated yet to the 1.23.4.
…ot/cherry-pick-2424-to-release-0.12

[release-0.12] 🌱 go.mod: stick to 1.23.0
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 17, 2025
@openshift-ci
Copy link

openshift-ci bot commented Feb 17, 2025

Hi @shiftstack-merge-bot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@EmilienM
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 17, 2025
@EmilienM
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2025
@openshift-ci
Copy link

openshift-ci bot commented Feb 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2025
@EmilienM
Copy link
Member

/lgtm
/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. labels Feb 17, 2025
@openshift-ci
Copy link

openshift-ci bot commented Feb 17, 2025

@shiftstack-merge-bot[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 3b25d0b link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 1bbbeb8 into openshift:main Feb 17, 2025
8 of 9 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the merge-bot-main branch February 17, 2025 18:38
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: openstack-cluster-api-controllers
This PR has been included in build openstack-cluster-api-controllers-container-v4.19.0-202502172038.p0.g1bbbeb8.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants