OCPCLOUD-2857: Set infrastructureRef.Namespace in Cluster object

[mdbooth]

Failing to set this breaks from CAPI v1.9 onwards.

/hold

[openshift-ci-robot]

@mdbooth: This pull request references OCPCLOUD-2857 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Failing to set this breaks from CAPI v1.9 onwards.

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[mdbooth]

The e2e tests will run this against CAPI 1.8. I have manually tested it against openshift/cluster-api#230 which updates to CAPI 1.9 and confirmed that it now works.

$ kc -n openshift-cluster-api get openstackclusters.infrastructure.cluster.x-k8s.io
NAME                     CLUSTER                  READY   NETWORK                                BASTION IP   AGE
mbooth-capi-test-9pmrl   mbooth-capi-test-9pmrl   true    12b9dc39-595f-4d89-b460-f4f813a23bdd                2m48s

[mdbooth]

/hold cancel

[openshift-ci]

@mdbooth: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	f67205c	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[EmilienM]

how did we miss that!
/lgtm
/approve
/label acknowledge-critical-fixes-only

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [EmilienM]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: openstack-cluster-api-controllers
This PR has been included in build openstack-cluster-api-controllers-container-v4.19.0-202502150007.p0.gc4c0495.assembly.stream.el9.
All builds following this will include this PR.

[mdbooth]

how did we miss that!

It works on 1.8. It would be a regression in CAPI 1.9, but we're not running the defaulting webhook which would have prevented it.