Skip to content

OCPBUGS-31277: Updating openstack-cluster-api-controllers-container image to be consistent with ART for 4.16 #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 2 commits into from
Apr 9, 2024
Merged

OCPBUGS-31277: Updating openstack-cluster-api-controllers-container image to be consistent with ART for 4.16 #301

openshift-merge-bot merged 2 commits into from
Apr 9, 2024

Conversation

@mandre
Copy link
Member

@mandre mandre commented Apr 9, 2024

Supersedes #300 since the go version change induced another change in go vendoring.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Apr 9, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 9, 2024

@mandre: This pull request references Jira Issue OCPBUGS-31277, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Supersedes #300 since the go version change induced another change in go vendoring.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Apr 9, 2024

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: sunzhaohua2.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@mandre: This pull request references Jira Issue OCPBUGS-31277, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Supersedes #300 since the go version change induced another change in go vendoring.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre mandre mentioned this pull request Apr 9, 2024
Closed
@openshift-ci openshift-ci bot requested review from MaysaMacedo and stephenfin April 9, 2024 08:45
@pierreprinetti
Copy link
Member

pierreprinetti commented Apr 9, 2024

generated files are out of date, run make generate

@mandre mandre force-pushed the art-4.16 branch 2 times, most recently from ea2948f to 0eebabe Compare April 9, 2024 12:01
@pierreprinetti pierreprinetti force-pushed the art-4.16 branch 2 times, most recently from b7ead7e to 7f5f5ed Compare April 9, 2024 14:24
@mandre @pierreprinetti
Vendoring after change of go version
5a04cee 
Update vendoring in both the `hack/tools` and `openshift` directories.

Adapt code and regenerate manifests.

Co-authored-by: Pierre Prinetti <pierreprinetti@redhat.com>
@pierreprinetti
Copy link
Member

pierreprinetti commented Apr 9, 2024

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2024
@openshift-ci
Copy link

openshift-ci bot commented Apr 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2024
@openshift-ci
Copy link

openshift-ci bot commented Apr 9, 2024

@mandre: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit bbf8955 into openshift:main Apr 9, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 9, 2024

@mandre: Jira Issue OCPBUGS-31277: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-31277 has not been moved to the MODIFIED state.

Details

In response to this:

Supersedes #300 since the go version change induced another change in go vendoring.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mandre mandre deleted the art-4.16 branch April 9, 2024 16:24
@openshift-bot
Copy link

openshift-bot commented Apr 10, 2024

[ART PR BUILD NOTIFIER]

This PR has been included in build openstack-cluster-api-controllers-container-v4.16.0-202404100642.p0.gbbf8955.assembly.stream.el9 for distgit openstack-cluster-api-controllers.
All builds following this will include this PR.

pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 19, 2024
@openshift-merge-bot @pierreprinetti
Merge pull request openshift#301 from shiftstack/art-4.16
04434e0 
OCPBUGS-31277: Updating openstack-cluster-api-controllers-container image to be consistent with ART for 4.16
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 19, 2024
@openshift-merge-bot @pierreprinetti
Merge pull request openshift#301 from shiftstack/art-4.16
f953a76 
OCPBUGS-31277: Updating openstack-cluster-api-controllers-container image to be consistent with ART for 4.16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaysaMacedo MaysaMacedo Awaiting requested review from MaysaMacedo

@stephenfin stephenfin Awaiting requested review from stephenfin

Assignees

@pierreprinetti pierreprinetti

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mandre @openshift-ci-robot @pierreprinetti @openshift-bot