Skip to content

Conversation

@mandre
Copy link
Member

@mandre mandre commented Jan 3, 2024

This previously caused the job to fail with:

 ✗ [High] the referenced anchor is not defined: */vendor/**
   ID: 62e8960c-5e98-4900-b60c-b67ea2a03767
   Path: .snyk, line 7
   Info: the referenced anchor is not defined: */vendor/**

This previously caused the job to fail with:

     ✗ [High] the referenced anchor is not defined: */vendor/**
       ID: 62e8960c-5e98-4900-b60c-b67ea2a03767
       Path: .snyk, line 7
       Info: the referenced anchor is not defined: */vendor/**
@openshift-ci openshift-ci bot requested review from mdbooth and stephenfin January 3, 2024 13:46
@pierreprinetti
Copy link
Member

Do you want to exclude /hack scripts as well?

@mandre
Copy link
Member Author

mandre commented Jan 3, 2024

Do you want to exclude /hack scripts as well?

Yes, I was looking at the errors and indeed, that seems better to also ignore the hack directory.

We can ignore things that do not end up in the product.
@pierreprinetti
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2024
@openshift-ci
Copy link

openshift-ci bot commented Jan 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2024
@openshift-ci
Copy link

openshift-ci bot commented Jan 3, 2024

@mandre: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 7bb5f49 into openshift:main Jan 3, 2024
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build openstack-cluster-api-controllers-container-v4.16.0-202401031952.p0.g7bb5f49.assembly.stream for distgit openstack-cluster-api-controllers.
All builds following this will include this PR.

@pierreprinetti pierreprinetti deleted the fix-snyk branch January 3, 2024 21:08
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
encounter issue when kubeadm start as swap is on
so disable swap during start of user-data execution.

Fixes Bug openshift#292
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants