Skip to content

DNM - used for testing etcd block device early #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
EmilienM wants to merge 4 commits into from
Closed

DNM - used for testing etcd block device early #276

EmilienM wants to merge 4 commits into from

Conversation

@EmilienM
Copy link
Member

@EmilienM EmilienM commented Oct 18, 2023 •
edited
Loading

DO NOT REVIEW - IGNORE IT - I'm using it for testing purpose.

  • UPSTREAM 1668: Additional data volumes for machines
  • CARRY: Bump Gophercloud to v1.7.0
  • Add ephemeral storage support to the AdditionalBlockDevices

/hold

Matt Pryor and others added 2 commits October 18, 2023 14:59
@EmilienM
UPSTREAM 1668: Additional data volumes for machines
a750ce9 
We now have the ability for a machine to have additional
block devices to be attached.

Here is an example on how to use `additionalBlockDevices`
for adding additional Cinder volumes attached to the server instance:

```yaml
additionalBlockDevices:
- nameSuffix: dbvol1
  size: 50
  volumeType: my-volume-type
  availabilityZone: az0
  tag: database
```

Co-authored-by: Matt Pryor <matt@stackhpc.com>
Co-authored-by: Emilien Macchi <emilien@redhat.com>
(cherry picked from commit 94d9690)
(cherry picked from commit edb9ef4)
@EmilienM
CARRY: Bump Gophercloud to v1.7.0
46f2d41 
Edit go.mod to bump Gophercloud to v1.7.0 instead of v1.3.0 then:
```
go mod tiny
go mod vendor
```

(cherry picked from commit bb659ab)
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 18, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from emilienm. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@EmilienM @mandre
Add ephemeral storage support to the AdditionalBlockDevices
110efd9 
Co-authored-by: Emilien Macchi <emilien@redhat.com>
Co-authored-by: Martin André <m.andre@redhat.com>
(cherry picked from commit 51b1996)
@EmilienM EmilienM force-pushed the etcd_bd branch 2 times, most recently from c23dda9 to 40e2c50 Compare October 21, 2023 00:49
@EmilienM
Proposal v2
522c65a 
(cherry picked from commit dce1886)
@openshift-ci
Copy link

openshift-ci bot commented Oct 21, 2023

@EmilienM: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@EmilienM EmilienM closed this Oct 26, 2023
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
@dims @pierreprinetti
Add more reviewers for the repository (openshift#276)
754b0c4 
Change-Id: I5f84f77c80a10c947444219580fe2f99dda75255
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaysaMacedo MaysaMacedo Awaiting requested review from MaysaMacedo

@stephenfin stephenfin Awaiting requested review from stephenfin

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@EmilienM