UPSTREAM 1726: Replace kustomize vars with replacements

[mdbooth]

(cherry picked from commit 661c0ff)

/hold

[openshift-ci]

@mdbooth: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[mdbooth]

This is a clean backport of kubernetes-sigs#1726. The upstream change is a non-functional refactor which replaces the use of kustomize vars with kustomize replacements. vars is deprecated, so this had to happen at some point anyway. It is non-functional because the output is identical before and after the change.

The reason to backport it here, and the reason I wrote it, is that vars don't work correctly when a layer removes an object referenced by vars, but replacements does. Specifically, vars is referencing the cert-manager certificate. We don't use cert-manager in OpenShift, so we remove it (in my unmerged feature branch under #266). We need this fix in order to be able to do that.

[mandre]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [mandre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mdbooth]

/hold cancel