[release-4.11] OCPBUGS-2626: Ensure network defs without subnet follow noAllowedAddressPairs #248
Conversation
…essPairs Commit 855a22c introduced a bug that caused network definitions without subnets (the one you would get when setting `additionalNetworkIDs` in your `install-config.yaml`) caused the noAllowedAddressPairs property to be skipped while creating the port. This may in turn caused machine-api to fail creating the port because it does not have the permission to create a port with allowed_address_pair, which is often the case when using provider networks.
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-2508 has been cloned as Jira Issue OCPBUGS-2626. Retitling PR to link against new bug. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/severity-important
|
/lgtm |
openshift-ci-robot
added
the
jira/invalid-bug
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-2626, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierreprinetti The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@pierreprinetti: This pull request references Jira Issue OCPBUGS-2626, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: eurijon. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@pierreprinetti: Overrode contexts on behalf of pierreprinetti: ci/prow/e2e-openstack DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
sdodson
added
cherry-pick-approved
|
If this code is dead in 4.11+ and expect to have to continue backporting a significant number of fixes to 4.10 in the future we may want to come up with a strategy speed things up without introducing risk. I've gone ahead and added labels to ensure this merges soon and we can unblock the 4.10 backport. |
|
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-2626 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@sdodson Thank you. We ended up going "FastFix". We don't expect tons of fixes against the 4.10 code, and to be honest I decided to backport the original patch (#245) precisely to test out how to do things (the original issue had a workaround; the fact that my patch introduced a regression, for which this #249 is the fix, is an unexpected twist). I believe that the most efficient strategy for the future might be to forget about the |
|
@pierreprinetti that's fine with me if there's no meaningful way for QE to test fixes to this codebase in 4.11, just please exercise extra diligence in pre-merge testing (with QE) so that we're not iterating on fixes directly in release-4.10. |
6 participants
This is an automated cherry-pick of #247
/assign pierreprinetti