Skip to content

Bug 2097728: Don't fail on server delete returning HTTP 404 #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stephenfin wants to merge 2 commits into from
Closed

Bug 2097728: Don't fail on server delete returning HTTP 404 #238

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
652b30b
Bug 2097728: Don't fail on server delete returning HTTP 404
stephenfin Jun 21, 2022
eb249b0
Lower logging level
stephenfin Jun 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion pkg/cloud/openstack/clients/machineservice.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1065,7 +1065,18 @@ func (is *InstanceService) InstanceDelete(id string) error {
}

// delete instance
return servers.Delete(is.computeClient, id).ExtractErr()
err = servers.Delete(is.computeClient, id).ExtractErr()

// we don't report HTTP 404 since that's okay - the server is gone already
if err != nil {
if httpStatus, ok := err.(gophercloud.ErrDefault404); ok {
if httpStatus.Actual == 404 {
klog.Warningf("Couldn't find instance %v to delete: %v", id, err)
Comment thread
stephenfin marked this conversation as resolved.
Outdated
return nil
}
}
}
return err
}

func GetTrunkSupport(is *InstanceService) (bool, error) {
Expand Down