update for golang 1.17 #207
Conversation
|
/retest |
|
Not sure if the openstack-proxy job is supposed to pass. Let's give it another try: |
|
update
|
This change updates the go.mod, ci-operator.yaml and Dockerfiles to use golang 1.17, it also updates the vendor directory. The vendor directory was updated by running `go mod vendor && go mod tidy && go mod verify`. Also ran `go fmt` to cleanup the build tags for 1.17.
|
update
|
|
@elmiko: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| RUN go build -o ./machine-controller-manager ./cmd/manager | ||
|
|
||
| FROM registry.ci.openshift.org/origin/4.8:base | ||
| FROM registry.ci.openshift.org/openshift/origin-v4.0:base |
There was a problem hiding this comment.
4.0? Is this intentional, or was it meant to be 4.10?
There was a problem hiding this comment.
i tried to make this look like our other community-facing images, see the aws provider for example https://github.com/openshift/cluster-api-provider-aws/blob/master/Dockerfile#L8
my thinking here is that the "Dockerfile" files are for making publicly available images and the "Dockerfile.rhel" is for making the subscription-based images. so i was basically trying to make the community ones look similar, and afaik they all work with that 4.0 base.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierreprinetti The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
5 participants
This change updates the go.mod and Dockerfiles to use golang 1.17, it
also updates the vendor directory. The vendor directory was updated by
running
go mod vendor && go mod tidy && go mod verify.