[release-4.7] Bug 1989041: Eliminate instanceCreate volume leak #194

openshift-cherrypick-robot · 2021-08-02T09:41:14Z

This is an automated cherry-pick of #192

/assign pierreprinetti

InstanceCreate is a method that creates a server. If the server is set to boot from volume, and an image ID is passed, the method creates the root volume prior to creating the server. The root volume is set to be destroyed when the associated server is destroyed. However, if the server fails to create (for example, because of quota issues), the volume is never associated to a server and the automatic deletion is never triggered. At every round of retry, a new volume will be created, possibly until volume quota is reached (or server creation is successful). This results in a leakage of unused volumes. With this change, a newly created root volume is explicitly deleted in the event of an early failure of InstanceCreate. That is to say: if InstanceCreate creates a volume, that volume will be deleted if any of the next steps fail and cause the server never to be created. Note that this patch leaves unmodified the lifespan of a volume associated to a server, regardless if the server ever reaches an ACTIVE state. Co-Authored-By: Matthew Booth <mbooth@redhat.com>

openshift-ci · 2021-08-02T09:41:26Z

@openshift-cherrypick-robot: Bugzilla bug 1985015 has been cloned as Bugzilla bug 1989041. Retitling PR to link against new bug.
/retitle [release-4.7] Bug 1989041: Eliminate instanceCreate volume leak

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-08-02T09:41:30Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1989041, which is invalid:

expected dependent Bugzilla bug 1985015 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mandre

/lgtm
/hold pending CI and valid BZ

pierreprinetti · 2021-08-09T08:17:35Z

CI is fine and the "bugzilla/invalid-bug" blocking label has properly been applied; removing the manual hold.
/hold cancel

Updating the Bugzilla status; should be ON_QA
/bugzilla refresh

openshift-ci · 2021-08-09T08:17:37Z

@pierreprinetti: An error was encountered searching for bug 1989041 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


could not unmarshal response body: invalid character '<' looking for beginning of value

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti · 2021-08-09T08:17:57Z

/bugzilla refresh

openshift-ci · 2021-08-09T08:17:59Z

@pierreprinetti: An error was encountered searching for bug 1989041 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


could not unmarshal response body: invalid character '<' looking for beginning of value

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-08-10T01:01:07Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-08-10T01:01:12Z

@openshift-bot: This pull request references Bugzilla bug 1989041, which is invalid:

expected dependent Bugzilla bug 1985015 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-08-11T01:00:28Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-08-11T01:00:33Z

@openshift-bot: This pull request references Bugzilla bug 1989041, which is invalid:

expected dependent Bugzilla bug 1985015 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-08-12T01:01:15Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-08-12T01:01:20Z

@openshift-bot: This pull request references Bugzilla bug 1989041, which is invalid:

expected dependent Bugzilla bug 1985015 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-08-13T01:00:24Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-08-13T01:00:31Z

@openshift-bot: This pull request references Bugzilla bug 1989041, which is invalid:

expected dependent Bugzilla bug 1985015 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-08-14T01:00:56Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-08-14T01:02:01Z

@openshift-bot: This pull request references Bugzilla bug 1989041, which is invalid:

expected dependent Bugzilla bug 1985015 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-08-15T01:00:50Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-08-15T01:00:54Z

@openshift-bot: This pull request references Bugzilla bug 1989041, which is invalid:

expected dependent Bugzilla bug 1985015 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-08-16T01:00:54Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-08-16T01:00:58Z

@openshift-bot: This pull request references Bugzilla bug 1989041, which is invalid:

expected dependent Bugzilla bug 1985015 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-08-17T01:00:29Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-08-17T01:00:33Z

@openshift-bot: This pull request references Bugzilla bug 1989041, which is invalid:

expected dependent Bugzilla bug 1985015 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-08-18T01:01:08Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-08-18T01:03:48Z

@openshift-bot: This pull request references Bugzilla bug 1989041, which is invalid:

expected dependent Bugzilla bug 1985015 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-08-19T01:00:36Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-08-19T01:00:40Z

@openshift-bot: This pull request references Bugzilla bug 1989041, which is invalid:

expected dependent Bugzilla bug 1985015 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti · 2021-08-19T07:14:04Z

/bugzilla refresh

openshift-ci · 2021-08-19T07:15:16Z

@pierreprinetti: This pull request references Bugzilla bug 1989041, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.z) matches configured target release for branch (4.7.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1985015 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1985015 targets the "4.8.z" release, which is one of the valid target releases: 4.8.0, 4.8.z
bug has dependents

Requesting review from QA contact:
/cc @eurijon

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-08-19T07:15:17Z

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: eurijon.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti · 2021-08-19T07:19:01Z

/approve

openshift-ci · 2021-08-19T07:20:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [pierreprinetti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pierreprinetti · 2021-08-25T11:42:55Z

/close
see https://bugzilla.redhat.com/show_bug.cgi?id=1989041#c1

openshift-ci · 2021-08-25T11:42:57Z

@pierreprinetti: Closed this PR.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-08-25T11:43:02Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1989041. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot assigned pierreprinetti Aug 2, 2021

openshift-cherrypick-robot mentioned this pull request Aug 2, 2021

Bug 1985015: Eliminate instanceCreate volume leak #192

Merged

openshift-ci bot requested review from iamemilio and mandre August 2, 2021 09:41

openshift-ci bot changed the title ~~[release-4.7] Bug 1985015: Eliminate instanceCreate volume leak~~ [release-4.7] Bug 1989041: Eliminate instanceCreate volume leak Aug 2, 2021

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 2, 2021

mandre reviewed Aug 2, 2021

View reviewed changes

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2021

openshift-ci bot assigned mandre Aug 2, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2021

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2021

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 19, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2021

openshift-ci bot closed this Aug 25, 2021

EmilienM mentioned this pull request Jan 31, 2023

Manual rebase on upstream #252

Closed

pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024

Use corev1.SecretReference for CloudsSecrets too (openshift#194)

34708a1

[release-4.7] Bug 1989041: Eliminate instanceCreate volume leak #194

[release-4.7] Bug 1989041: Eliminate instanceCreate volume leak #194

Uh oh!

Conversation

openshift-cherrypick-robot commented Aug 2, 2021

Uh oh!

openshift-ci bot commented Aug 2, 2021

Uh oh!

openshift-ci bot commented Aug 2, 2021

Uh oh!

mandre left a comment

Choose a reason for hiding this comment

Uh oh!

pierreprinetti commented Aug 9, 2021

Uh oh!

openshift-ci bot commented Aug 9, 2021

Uh oh!

pierreprinetti commented Aug 9, 2021

Uh oh!

openshift-ci bot commented Aug 9, 2021

Uh oh!

openshift-bot commented Aug 10, 2021

Uh oh!

openshift-ci bot commented Aug 10, 2021

Uh oh!

openshift-bot commented Aug 11, 2021

Uh oh!

openshift-ci bot commented Aug 11, 2021

Uh oh!

openshift-bot commented Aug 12, 2021

Uh oh!

openshift-ci bot commented Aug 12, 2021

Uh oh!

openshift-bot commented Aug 13, 2021

Uh oh!

openshift-ci bot commented Aug 13, 2021

Uh oh!

openshift-bot commented Aug 14, 2021

Uh oh!

openshift-ci bot commented Aug 14, 2021

Uh oh!

openshift-bot commented Aug 15, 2021

Uh oh!

openshift-ci bot commented Aug 15, 2021

Uh oh!

openshift-bot commented Aug 16, 2021

Uh oh!

openshift-ci bot commented Aug 16, 2021

Uh oh!

openshift-bot commented Aug 17, 2021

Uh oh!

openshift-ci bot commented Aug 17, 2021

Uh oh!

openshift-bot commented Aug 18, 2021

Uh oh!

openshift-ci bot commented Aug 18, 2021

Uh oh!

openshift-bot commented Aug 19, 2021

Uh oh!

openshift-ci bot commented Aug 19, 2021

Uh oh!

pierreprinetti commented Aug 19, 2021

Uh oh!

openshift-ci bot commented Aug 19, 2021

Uh oh!

openshift-ci bot commented Aug 19, 2021

Uh oh!

pierreprinetti commented Aug 19, 2021

Uh oh!

openshift-ci bot commented Aug 19, 2021

Uh oh!

pierreprinetti commented Aug 25, 2021

Uh oh!

openshift-ci bot commented Aug 25, 2021

Uh oh!

openshift-ci bot commented Aug 25, 2021

Uh oh!

Reviewers

Assignees

Labels