Skip to content

Conversation

@Fedosin
Copy link

@Fedosin Fedosin commented Jun 14, 2021

No description provided.

@openshift-ci openshift-ci bot requested review from iamemilio and mandre June 14, 2021 13:37
@Fedosin
Copy link
Author

Fedosin commented Jun 15, 2021

/test e2e-openstack

@Fedosin
Copy link
Author

Fedosin commented Jun 15, 2021

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jun 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2021
@Fedosin
Copy link
Author

Fedosin commented Jul 13, 2021

/retest

@pierreprinetti
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2021
@openshift-merge-robot openshift-merge-robot merged commit 5974958 into openshift:master Jul 23, 2021
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
In an isolated scenario where only the actuator is being used (no
clusterctl or any of the CAPO scripts) the kubelet version may not
be required. Pre-built images may come with a pre-installed kubelet or
versions could be provided through different means.

This PR removes the check in favor of letting the templates
manage/verify they have all the data they need.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants